Don't call SCM#calcPollingingBaseline if SCM#checkout fails #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the JavaDocs for SCM#calcRevisionsFromBuild, if says: This method is called after source code is checked out for the given build (that is, after SCM#checkout has finished successfully.) This appears to make sense; after you have a known SCM state, you calculate the revisions. It doesn't explicitly state it, but it implies that it won't be called if checkout failed. In those cases, the state may well not be known, and it doesn't make sense to attempt to calculate the revisions. The behavior in AbstractProject#checkout has been to always call calcPollingBaseline, regardless of whether checkout failed or succeeded. This is causing misleading error output for the mercurial plugin. With this change, AbstractProject will only do the calculations when checkout succeeds.
kutzi
added a commit
that referenced
this pull request
Dec 4, 2011
Don't call SCM#calcPollingingBaseline if SCM#checkout fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the JavaDocs for SCM#calcRevisionsFromBuild, if says:
This method is called after source code is checked out for the given build (that is, after SCM#checkout has finished successfully.)
This appears to make sense; after you have a known SCM state, you calculate the revisions. It doesn't explicitly state it, but it
implies that it won't be called if checkout failed. In those cases, the state may well not be known, and it doesn't make sense to
attempt to calculate the revisions.
The behavior in AbstractProject#checkout has been to always call calcPollingBaseline, regardless of whether checkout failed or
succeeded. This is causing misleading error output for the mercurial plugin. With this change, AbstractProject will only do the
calculations when checkout succeeds.