Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable test temporarily to get the release out #3274

Merged
merged 1 commit into from Jan 29, 2018
Merged

Disable test temporarily to get the release out #3274

merged 1 commit into from Jan 29, 2018

Conversation

batmat
Copy link
Member

@batmat batmat commented Jan 29, 2018 •
edited

Revert temporarily the test introduced in #3233

Note: this test is wrong, the production code is correct.
So that is why disabling this test until we fix it is OK.

Tested locally:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running hudson.util.AtomicFileWriterTest
[WARNING] Tests run: 8, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.113 s - in hudson.util.AtomicFileWriterTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 8, Failures: 0, Errors: 0, Skipped: 1
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS

@daniel-beck

@batmat
Disable test temporarily to get the release out
9123745 
Note: this test is wrong, the production code is correct.
So that is why disabling this test until we fix it is OK.
daniel-beck
daniel-beck approved these changes Jan 29, 2018
View reviewed changes
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be merged as soon as the PR build passes.

@daniel-beck daniel-beck merged commit 631ed7a into jenkinsci:master Jan 29, 2018
@batmat batmat mentioned this pull request Jan 30, 2018
Merged
4 tasks
@batmat batmat deleted the JENKINS-48407-disable-test-temporarily branch January 30, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-beck daniel-beck daniel-beck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@batmat @daniel-beck