[JENKINS-48775] HACKY HACKY FIX

[stephenc]

• Cheat and try a HTTP url if the proxy has never been accessed with a HTTP url before attempting a HTTPS url

See JENKINS-48775.

Proposed changelog entries

• The JRE does will only discover authentication for a HTTP proxy when accessing a HTTP url. If the only URLs accessed are HTTPS then the authentication will never be discovered, so now the proxy connection will attempt to connect to a HTTP url if the first URL to access is HTTPS url

Submitter checklist

• JIRA issue is well described
• Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
  * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
• Appropriate autotests or explanation to why this change has no tests
• For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@daniel-beck @rtyler @jenkinsci/code-reviewers

This is a screaming dirty hack... but should work ;-)

[oleg-nenashev]

Please get @reviewbybees first

…

On Feb 24, 2018 20:42, "Stephen Connolly" ***@***.***> wrote: @stephenc <https://github.com/stephenc> requested your review on: jenkinsci/jenkins#3283 <#3283> [JENKINS-48775] HACKY HACKY FIX. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#3283 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC3IoJSCLkdS68cN8CgfL6UQvwWuzcU_ks5tYGZBgaJpZM4R7O1c> .

[stephenc]

@oleg-nenashev we stopped that iirc.

[oleg-nenashev]

@stephenc responded in the private message. Just to set the expectation, I have no plan to review this PR. If you are unable to get reviews from your colleagues or from other Jenkins reviewers, you have an option to merge it on your own. So far Jenkins project has no merge policy, so any Core team member is eligible to merge whatever he wants.

[stephenc]

I think this should be "http" not "https" but the only side effect is that we apply the workaround of attempting a connect in cases where it might not already be needed