Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dutch translation #3323

Merged
merged 4 commits into from Mar 10, 2018
Merged

Improve dutch translation #3323

merged 4 commits into from Mar 10, 2018

Conversation

Ka-Wing
Copy link
Contributor

@Ka-Wing Ka-Wing commented Mar 4, 2018

See JENKINS-49901.

Issue should say enough. As these are text translations, I don't think tests are needed.
I am a native speaker by the way.

Proposed changelog entries

  • Improved Dutch translation.

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

Dutch natives.

@oleg-nenashev
Copy link
Member

CC @vStone who may be interested (#3286)

@oleg-nenashev
Copy link
Member

@lange88 are you fine with the changes?

vStone
vStone suggested changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@vStone vStone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've went through it, finally. some remarks added.

core/src/main/resources/hudson/model/Fingerprint/index_nl.properties Outdated
This\ file\ has\ not\ been\ used\ anywhere\ else.=Dit bestand werd nog nergens anders gebruikt.
This\ file\ has\ been\ used\ in\ the\ following\ places=Dit bestand werd op de volgende plaatsen gebruikt.
This\ file\ has\ not\ been\ used\ anywhere\ else.=Dit bestand is nergens anders gebruikt.
This\ file\ has\ been\ used\ in\ the\ following\ places=Dit bestand is volgende plaatsen gebruikt.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dit bestand is op volgende plaatsen gebruikt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, should be "Dit bestand is op de volgende plaatsen gebruikt.".

core/src/main/resources/hudson/model/Job/buildTimeTrend_nl.properties Outdated
@@ -25,4 +25,4 @@ title={0} Duurtrend van een bouwpoging
Build=Bouwpoging
Build\ Time\ Trend=Bouw tijd trend
Duration=Duur
More\ than\ 1\ builds\ are\ needed\ for\ the\ trend\ report.=Er dienen minsten 2 bouwpogingen plaatsgevonden te hebben, vooralleer een trendrapport kan opgesteld worden.
More\ than\ 1\ builds\ are\ needed\ for\ the\ trend\ report.=Er dienen minstens 2 bouwpogingen plaats te hebben gevonden, voordat een trendrapport kan opgesteld worden.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma here is not needed.

Er dienen minstens 2 bouwpogingen plaats te hebben gevonden voordat een trendrapport kan opgesteld worden.

core/src/main/resources/hudson/model/MyView/newViewDetail_nl.properties Outdated
@@ -1,3 +1,3 @@
# This file is under the MIT License by authors

blurb=Dit overzicht toont automatisch alle bouw opdrachten de huidige gebruiker toegang toe heeft.
blurb=Dit overzicht toont automatisch alle bouwopdrachten de huidige gebruiker toegang toe heeft.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dit overzicht toont automatisch alle bouwopdrachten waar de huidige gebruiker toegang toe heeft.

core/src/main/resources/hudson/model/Run/logKeep_nl.properties Outdated
Don't\ keep\ this\ build\ forever=Deze bouwpoging niet eeuwig bijhouden.
Keep\ this\ build\ forever=Bewaar deze Build eeuwig
Don't\ keep\ this\ build\ forever=Deze bouwpoging niet voor altijd bijhouden.
Keep\ this\ build\ forever=Bewaar deze Build voor altijd.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should translate build to 'bouwpoging' always or never.

Bewaar deze bouwpoging voor altijd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I have overlooked it. I have changed it to "bouwpoging"

core/src/main/resources/hudson/util/IncompatibleServletVersionDetected/index_nl.properties Outdated
@@ -22,5 +22,5 @@

Error=Fout
errorMessage=\
Blijkbaar ondersteunt uw servlet container de servlet versie 2.4 niet!\
Blijkbaar ondersteunt uw servletcontainer de servlet versie 2.4 niet!\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blijkbaar bugs me here. We merken dat ?

core/src/main/resources/hudson/util/NoTempDir/index_nl.properties Outdated
folder te gebruiken :{0}\
Bestaat deze folder? Is deze folder beschrijfbaar door de gebruiker\
map te gebruiken :{0}\
Bestaat deze map? Is deze map beschrijfbaar door de gebruiker\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beschrijfbaar -> wijzigbaar

core/src/main/resources/jenkins/model/Jenkins/projectRelationship-help_nl.properties Outdated
de,door een bouwpoging, opgeleverde artefacten.
For\ this\ feature\ to\ work,\ the\ following\ conditions\ need\ to\ be\ met\:=Aan volgende voorwaarden dient voldaan om met deze functionaliteit te werken:
de door een bouwpoging opgeleverde artefacten.
For\ this\ feature\ to\ work,\ the\ following\ conditions\ need\ to\ be\ met\:=De volgende voorwaarden dient voldaan te worden om met deze functionaliteit te werken:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De volgende voorwaarden dienen voldaan...

core/src/main/resources/lib/hudson/project/config-publishers_nl.properties
Post-build\ Actions=Acties voor na de bouwpoging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acties uit te voeren na de bouwpoging

core/src/main/resources/lib/hudson/project/config-publishers2_nl.properties Outdated
Add\ post-build\ action=Toevoegen actie na bouwpoging
Post-build\ Actions=Acties na bouwpoging
Add\ post-build\ action=Toevoegen actie voor na de bouwpoging
Post-build\ Actions=Acties voor na de bouwpoging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acties uit te voeren na / voor de bouwpoging

core/src/main/resources/lib/layout/breadcrumbBar_nl.properties Outdated

ENABLE\ AUTO\ REFRESH=Automatisch herladen inschakelen
ENABLE\ AUTO\ REFRESH=Automatisch vernieuwen inschakelen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalization should match original string

@Ka-Wing
Copy link
Contributor Author

Ka-Wing commented Mar 7, 2018

@vStone I have made changes according to your suggestions. Can you check them again please?

@lange88
Copy link

lange88 commented Mar 8, 2018

Changes look good @Ka-Wing @oleg-nenashev

@oleg-nenashev oleg-nenashev self-assigned this Mar 8, 2018
vStone
vStone approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@vStone vStone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oleg-nenashev oleg-nenashev merged commit 4f33d8a into jenkinsci:master Mar 10, 2018
@oleg-nenashev
Copy link
Member

Thanks a lot @Ka-Wing @lange88 @vStone !

@Ka-Wing
Copy link
Contributor Author

Ka-Wing commented Mar 10, 2018

@oleg-nenashev You are welcome. I am happy to be able to help.

@Ka-Wing Ka-Wing deleted the ImproveDutchTranslation branch March 10, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vStone vStone vStone approved these changes

Assignees

@oleg-nenashev oleg-nenashev

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Ka-Wing @oleg-nenashev @lange88 @vStone