Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-53462] Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox #3689

Merged
merged 1 commit into from Oct 20, 2018
Merged

[JENKINS-53462] Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox #3689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion war/src/main/webapp/scripts/hudson-behavior.js
View file
Open in desktop
Expand Up @@ -517,7 +517,16 @@ function registerRegexpValidator(e,regexp,message) {
* YUI Button widget.
*/
function makeButton(e,onclick) {
var h = e.onclick;
var type = e.type;
var h = e.onclick || function (event) {
if (type && type.toLowerCase() === 'submit') {
var target = event.target;
var form = findAncestor(target, "FORM");
form.submit();
} else {
//FIXME: get some usecases for else
}
};
var clsName = e.className;
var n = e.name;
var btn = new YAHOO.widget.Button(e,{});
Expand Down