Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-48220] list-jobs command shows all the items recursively of a given item #3711

Merged
merged 3 commits into from
Jan 27, 2019

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 29, 2018

See JENKINS-48220.

Proposed changelog entries

  • Entry 1: JENKINS-48220, Do not list items recursively when listing a folder.
type: bug
      message: >
        The <code>list-jobs</code> CLI command doesn't list items recursively when listing a folder.
      issue: 48220
      pull: 3711

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change).
  • Appropriate autotests or explanation to why this change has no tests

Desired reviewers

@oleg-nenashev , @jglick

@daniel-beck
Copy link
Member

Previously #3556

CC @olivergondza

Copy link
Member

@olivergondza olivergondza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change. However, I fund the suggested changelog message a bit confusing. How about: "Do not list items recursively when listing a folder"?

@v1v
Copy link
Member Author

v1v commented Oct 30, 2018

Awesome! Just changed the changelog as suggested, besides that, I didn't want to change the behaviour for the View, but when the item is a view, the list-jobs does list all the items recursively. I'm not against of doing it but the ticket didn't mention anything on that regard.

Do you think it's a good idea to change the behaviour for the view as done for the folders?

@v1v
Copy link
Member Author

v1v commented Nov 11, 2018

Is there anything else to be done? If so, please let me know

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect a flag like --recursive available for this CLI command.
But I agree with the change of the default behavior

@oleg-nenashev oleg-nenashev merged commit ad06551 into jenkinsci:master Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants