Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-38719] Console note/annotator script.js URLs must include SESSION_HASH #3757

Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 13, 2018

To properly invalidate scripts across restarts. A user of jenkinsci/workflow-job-plugin#111 reported seeing the old version of a script.js, which I suspect was caused by this.

Proposed changelog entries

  • Do not cache CSS/JS resource files for console annotations like Timestamper Plugin across Jenkins restarts.

…de the SESSION_HASH in the URL to properly invalidate scripts across restarts.
@jglick jglick changed the title Functions.generateConsoleAnnotationScriptAndStylesheet needs to include the SESSION_HASH in the URL Console note/annotator script.js URLs must include SESSION_HASH Nov 13, 2018
Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daniel-beck daniel-beck changed the title Console note/annotator script.js URLs must include SESSION_HASH [JENKINS-38719] Console note/annotator script.js URLs must include SESSION_HASH Nov 13, 2018
@daniel-beck
Copy link
Member

Supersedes #3692 I suppose -- this has a test, mine does not.

@jglick
Copy link
Member Author

jglick commented Nov 14, 2018

this has a test, mine does not

Also this one applies also to ConsoleAnnotationDescriptor whereas yours only fixes ConsoleAnnotatorFactory.

@jglick jglick merged commit 0331d47 into jenkinsci:master Nov 14, 2018
@jglick jglick deleted the generateConsoleAnnotationScriptAndStylesheet branch November 14, 2018 19:08
olivergondza pushed a commit that referenced this pull request Nov 22, 2018
…ndStylesheet

[JENKINS-38719] Console note/annotator script.js URLs must include SESSION_HASH

(cherry picked from commit 0331d47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants