Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest ExtensionList.lookupSingleton #3833

Merged
merged 1 commit into from Jan 6, 2019
Merged

Suggest ExtensionList.lookupSingleton #3833

merged 1 commit into from Jan 6, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 4, 2019

Taking advantage of #3021. Noticed from JENKINS-55361 description via #3828.

batmat
batmat approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@batmat batmat added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 6, 2019
@batmat batmat merged commit 8482421 into master Jan 6, 2019
@batmat batmat deleted the ExtensionList.lookupSingleton branch January 6, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batmat batmat batmat approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
2 participants
@jglick @batmat