Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-56398] Mobile friendly login / load / restart screens #3923

Merged
merged 3 commits into from Mar 8, 2019
Merged

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Mar 4, 2019

See JENKINS-56398.

Proposed changelog entries

  • Mobile friendly layout of the login, loading and restart screens

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • [n/a] Appropriate autotests or explanation to why this change has no tests
  • [n/a] For dependency updates: links to external changelogs and, if possible, full diffs

Note: the padding change makes no difference for login, but looks slightly better for restart.

Login before

login-current

Login after

login-mobile-friendly

Restart before

restart-current

Restart after

restart-mobile-friendly

@alecharp
Copy link
Member

alecharp commented Mar 5, 2019

Thank you for your contribution. Could you please include a pre and post fix screenshot on a desktop/laptop screen size? This way, anyone can see the difference and the impact? Thank you.

Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with screenshot it will be perfect.

@oleg-nenashev oleg-nenashev added the web-ui The PR includes WebUI changes which may need special expertise label Mar 5, 2019
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok from what I know about Web UIs and CSS (spoiler: not so much)

@zbynek
Copy link
Contributor Author

zbynek commented Mar 5, 2019

I updated the original comment with screenshots. Looking at the restart-mobile-friendly screenshot again I realized the heading lines were too close to each other. Fixed in second commit, result is below.
restart-mobile-friendly-2

@alecharp thanks for reviewing this! You also mentioned desktop screenshots: for desktop browsers this pull makes no difference. All screenshots were taken in Chrome dev tools emulating Pixel 2, I also tried the login on a physical Android 5'' phone.

Copy link
Contributor

@scherler scherler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@halkeye
Copy link
Member

halkeye commented Mar 5, 2019

for desktop browsers this pull makes no difference

There's a padding change, what does that actually do?

[Second Screenshot]

I was going to bring up the squished header, so with that fixed, I'm 👍 myself

@daniel-beck
Copy link
Member

How does this impact the signup form when having user signup enabled in the Jenkins user database?

@zbynek
Copy link
Contributor Author

zbynek commented Mar 6, 2019

@daniel-beck thanks, good point. Viewport added for signup in the last commit (also required removing min-width)
signup-mobile-friendly

@halkeye the padding was meant to make sure the text on reload screen does not go too close to vertical borders, but it also affects the current version of signup, so I removed the padding again. Restart is now like this:
restart-no-padding
I hope the latest version is OK.

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 8, 2019
@oleg-nenashev
Copy link
Member

I think this is ready to go.
Thanks @zbynek !

@oleg-nenashev oleg-nenashev merged commit 6bed423 into jenkinsci:master Mar 8, 2019
ad22 pushed a commit to ad22/jenkins that referenced this pull request Mar 21, 2019
…nsci#3923)

* JENKINS-56398 Mobile friendly login / load / restart screens

* [JENKINS-56398] increase line-height of heading

* [JENKINS-56398] mobile friendly layout for signup form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
6 participants