New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-56398] Mobile friendly login / load / restart screens #3923
Conversation
Thank you for your contribution. Could you please include a pre and post fix screenshot on a desktop/laptop screen size? This way, anyone can see the difference and the impact? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with screenshot it will be perfect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ok from what I know about Web UIs and CSS (spoiler: not so much)
I updated the original comment with screenshots. Looking at the @alecharp thanks for reviewing this! You also mentioned desktop screenshots: for desktop browsers this pull makes no difference. All screenshots were taken in Chrome dev tools emulating Pixel 2, I also tried the login on a physical Android 5'' phone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There's a padding change, what does that actually do?
I was going to bring up the squished header, so with that fixed, I'm 👍 myself |
How does this impact the signup form when having user signup enabled in the Jenkins user database? |
@daniel-beck thanks, good point. Viewport added for signup in the last commit (also required removing @halkeye the padding was meant to make sure the text on reload screen does not go too close to vertical borders, but it also affects the current version of signup, so I removed the padding again. Restart is now like this: |
I think this is ready to go. |
…nsci#3923) * JENKINS-56398 Mobile friendly login / load / restart screens * [JENKINS-56398] increase line-height of heading * [JENKINS-56398] mobile friendly layout for signup form
See JENKINS-56398.
Proposed changelog entries
Submitter checklist
* Use the
Internal:
prefix if the change has no user-visible impact (API, test frameworks, etc.)Note: the padding change makes no difference for login, but looks slightly better for restart.
Login before
Login after
Restart before
Restart after