Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localization support for default token name #3946

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Add localization support for default token name #3946

merged 1 commit into from
Apr 1, 2019

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Mar 23, 2019 •
edited by Wadeck

Don't need a test case

Proposed changelog entries

  • Improvement, Add localization support for default API token name

Submitter checklist

  • [n/a] JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • [n/a] For dependency updates: links to external changelogs and, if possible, full diffs

Wadeck
Wadeck approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@Wadeck Wadeck left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, I completely missed that one during the implementation, good job!

FYI typically, this one is a "quick fix" and does not require a Jira ticket

@LinuxSuRen
Copy link
Member Author

Enjoy this.

@batmat batmat added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 25, 2019
@batmat batmat merged commit d7719a3 into jenkinsci:master Apr 1, 2019
@LinuxSuRen LinuxSuRen deleted the i18n/api-token branch April 2, 2019 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batmat batmat batmat approved these changes

@Wadeck Wadeck Wadeck approved these changes

@varyvol varyvol varyvol approved these changes

@LakshanSS LakshanSS LakshanSS approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
5 participants
@LinuxSuRen @batmat @Wadeck @varyvol @LakshanSS