[JENKINS-50504] WorkspaceList.inUse should be keyed by String not FilePath so leases survive agent reconnections #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ePath so leases survive agent reconnections.
|
Judging by events I think this is not building due to JENKINS-54126. |
|
Looks logical, though I'm not familiar enough in this area to give a proper review. |
daniel-beck
approved these changes
Apr 8, 2019
|
Would like to wait for the current build to pass, so it can be picked up in the downstream PR and we can make sure that passes. |
daniel-beck
added
the
on-hold
jglick
added
ready-for-merge
abayer
approved these changes
Apr 9, 2019
|
Given approvals, I think we can merge it later today or so, if nobody objects in the meantime. |
dwnusbaum
approved these changes
Apr 9, 2019
jglick
added
the
ready-for-merge
|
@jglick Could you clarify whether we're waiting for an updated downstream PR? |
|
@daniel-beck not any longer, it went green with a deployment from this PR. |
jglick
added a commit
to jglick/workflow-durable-task-step-plugin
that referenced
this pull request
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-50504. Complements jenkinsci/workflow-durable-task-step-plugin#101.
Proposed changelog entries