Distinguish between new/aborted/disabled by ball color

[daniel-beck]

Implement suggestion from #3320 (comment). Minimally tested.

Try this PR: docker run --rm -ti -p 8080:8080 -e ID=3997 jenkins/core-pr-tester

Legend

List view

Proposed changelog entries

• Allow visually distinguishing between new projects, disabled projects, and those with aborted builds through differently shaded build balls.

Submitter checklist

• [n/a] JIRA issue is well described
• Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
  * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
• [n/a] Appropriate autotests or explanation to why this change has no tests
• [n/a] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@Ka-Wing

[jvz]

I suppose it's only slightly related, but you can likely just use SVG now as all web browsers support it. No need for rasterized copies.

[oleg-nenashev]

I would rather prefer something like #3320 (comment) instead of just adding more colors, but it is definitely a step forward. At least the balls now can be customized in Simple Theme plugin or in plugins like Green Balls.

[daniel-beck]

At least the balls now can be customized in Simple Theme plugin or in plugins like Green Balls.

They always could…? I am not introducing new files. Just the legend screen was weird.

[fcojfernandez]

Thanks @dbekel ! Really useful PR IMO

[jvz]

Oh, so it's this file that causes weird GUIs to appear in macOS.

[daniel-beck]

@jvz WDYM?

[jvz]

There seems to be a bug on macOS where referencing any AWT classes in a headless application will spawn a minimal GUI environment which is pretty much just an icon in the dock along with an application menu at the top. It steals focus from you while running the tests because macOS has yet to discover the joy of not allowing focus stealing. >:(

[jvz]

I'm not super familiar with the features of SVG, but is it possible to use a single SVG for the balls and use CSS to choose the color?

[daniel-beck]

I'm not super familiar with the features of SVG, but is it possible to use a single SVG for the balls and use CSS to choose the color?

I'm not going to figure out how to translate the animated icons into SVG for this, and without those, there's barely any benefit to that.

[jvz]

I'm not super familiar with the features of SVG, but is it possible to use a single SVG for the balls and use CSS to choose the color?

I'm not going to figure out how to translate the animated icons into SVG for this, and without those, there's barely any benefit to that.

• https://daneden.github.io/animate.css/
• https://en.wikipedia.org/wiki/SVG_animation
  • SMIL
  • CSS animations

[daniel-beck]

@jvz Feel free to amend this or propose a replacement PR.

[zbynek]

Animation can be done for raster images or SVGs on client side, quick demo
https://codepen.io/anon/pen/OGdxew

Coloring from CSS works when you inline the SVG but (AFAIK) not for <img src=blue.svg>. So it should be doable to have one SVG per color and kill the animated gifs, but

use a single SVG for the balls and use CSS to choose the color

sounds tricky.

[oleg-nenashev]

Maybe we could integrate it as is and create a follow-up ticket for enhancement which could be done by experts

[daniel-beck]

Yup.

Would like to mention this is a strict improvement over today even if the orbs are ugly, since the legend is now properly split up.

[daniel-beck]

Un-on-holding, as that was to get clarification about the Mac UI comment; it's unrelated to this PR.

[oleg-nenashev]

Should we land it into the weekly since it gets delayed?

[daniel-beck]

It's out now, so feel free to merge towards the next.

[oleg-nenashev]

OK, let's integrate it so that we start building a new weekly. Will merge it tomorrow if there is no negative feedback

[daniel-beck]

@stefandrissen This is not where you report bugs, please use our issue tracker for that.