Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless conditions #4163

Merged
merged 2 commits into from
Aug 23, 2019

Conversation

Egor18
Copy link
Contributor

@Egor18 Egor18 commented Aug 21, 2019

All these conditions are always true so they are meaningless and could be removed.
(I found this with the data-flow analyzer I'm working on)

@Egor18 Egor18 closed this Aug 21, 2019
@Egor18 Egor18 reopened this Aug 21, 2019
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also 👍 to @MRamonLeon proposal but otherwise your tool seems to be nice.

Please provide more information ;)

For the comparison, all those elements are also detected by IntelliJ inspectors. I did not try the opposite, to see if IntelliJ provides more entries or not, that's another story ;)

Co-Authored-By: Ramon Leon <manuelramonleonjimenez@gmail.com>
@Egor18
Copy link
Contributor Author

Egor18 commented Aug 22, 2019

@Wadeck, yes IntelliJ inspections are really nice.
Here is my pet-project: https://github.com/Egor18/jdataflow
I'm using Z3 SMT solver to find defects in logic, so sometimes the analysis could be a bit 'smarter' than in IntelliJ, but that's not the case right here.

@Wadeck
Copy link
Contributor

Wadeck commented Aug 23, 2019

@Egor18 I would try to have a look at your project, it seems promising :)

@oleg-nenashev oleg-nenashev added internal ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback labels Aug 23, 2019
@oleg-nenashev
Copy link
Member

Will merge it tomorrow if no negative feedback.
Likely we do not need to put it into the changelog on jenkins.io, no user impact.

@oleg-nenashev oleg-nenashev added the skip-changelog Should not be shown in the changelog label Aug 23, 2019
@oleg-nenashev oleg-nenashev merged commit fe1fc38 into jenkinsci:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
6 participants