Deprecating useless Util.getPastTimeString #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
res0nance
approved these changes
Aug 27, 2019
jglick
added
the
ready-for-merge
|
will merge tomorrow if no negative feedback |
MarkEWaite
added a commit
to MarkEWaite/docker-plugin
that referenced
this pull request
Aug 27, 2023
Replaced with OpenRewrite command:
mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \
-Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-jenkins:RELEASE \
-Drewrite.activeRecipes=org.openrewrite.jenkins.migrate.hudson.UtilGetPastTimeStringToGetTimeSpanString
jenkinsci/jenkins#4174 deprecates the API in a
2019 release of Jenkins core.
https://javadoc.jenkins.io/hudson/Util.html#getPastTimeString(long)
declares it deprecated.
6 tasks
MarkEWaite
added a commit
to jenkinsci/docker-plugin
that referenced
this pull request
Aug 27, 2023
Replaced with OpenRewrite command:
mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \
-Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-jenkins:RELEASE \
-Drewrite.activeRecipes=org.openrewrite.jenkins.migrate.hudson.UtilGetPastTimeStringToGetTimeSpanString
jenkinsci/jenkins#4174 deprecates the API in a
2019 release of Jenkins core.
https://javadoc.jenkins.io/hudson/Util.html#getPastTimeString(long)
declares it deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 25dcde3 this method does nothing useful, and does not do what its Javadoc still claimed.
Proposed changelog entries