[JENKINS-59383] Fix the DiskMonitorSpaceDescriptor toString() message when the monitor alert is not triggered #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batmat
approved these changes
Sep 16, 2019
zbynek
reviewed
Sep 16, 2019
| @@ -71,7 +71,10 @@ public DiskSpace(String path, long size) { | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
| return Messages.DiskSpaceMonitorDescriptor_DiskSpace_FreeSpaceTooLow(getGbLeft(), path); | |||
| if(triggered) { | |||
There was a problem hiding this comment.
Suggested change
| if(triggered) { | |
| if (triggered) { |
There was a problem hiding this comment.
@Dohbedoh could you please apply this? Obviously not a blocker.
oleg-nenashev
added
the
bug
oleg-nenashev
changed the title
oleg-nenashev
approved these changes
Sep 16, 2019
oleg-nenashev
added
the
ready-for-merge
MRamonLeon
approved these changes
Sep 16, 2019
varyvol
approved these changes
Sep 16, 2019
rsandell
approved these changes
Sep 16, 2019
jvz
approved these changes
Sep 16, 2019
alecharp
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-59383.
Proposed changelog entries
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@mention @reviewbybees