Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-60625] Prevent Jenkins page rendering from being blocked when the update center data parsing is in progress #4413

Merged
merged 3 commits into from Jan 4, 2020
Merged

[JENKINS-60625] Prevent Jenkins page rendering from being blocked when the update center data parsing is in progress #4413

merged 3 commits into from Jan 4, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 2, 2020

See JENKINS-60625.

Proposed changelog entries

  • Parsing update center metadata could be slow; Jenkins no longer blocks page rendering just to do so from administrative monitors.

daniel-beck
daniel-beck approved these changes Jan 2, 2020
View reviewed changes
core/src/main/java/hudson/model/UpdateCenter.java
public boolean isActivated() {
if (!Jenkins.get().getUpdateCenter().isSiteDataReady()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: I missed this change in the original version of the previous review.

@jglick @daniel-beck
Be explicit that UpdateSite.hasUnparsedData is not intended as an API.
e621b6e 
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
@jglick jglick added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 3, 2020
oleg-nenashev
oleg-nenashev approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@oleg-nenashev oleg-nenashev added plugin-api-changes Changes the API of Jenkins available for use in plugins. rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 3, 2020
@oleg-nenashev oleg-nenashev changed the title [JENKINS-60625] Introduced UpdateCenter.isSiteDataReady for use from administrative monitors [JENKINS-60625] Prevent Jenkins page rendering from being blocked when the update center data parsing is in progress Jan 3, 2020
@oleg-nenashev
Copy link
Member

I plan to merge it tomorrow if no negative feedback

@oleg-nenashev oleg-nenashev added the bug For changelog: Minor bug. Will be listed after features label Jan 3, 2020
@oleg-nenashev oleg-nenashev merged commit 9640790 into jenkinsci:master Jan 4, 2020
@jglick jglick deleted the UpdateCenter.isSiteDataReady-JENKINS-60625 branch January 4, 2020 14:19
@jglick jglick removed the plugin-api-changes Changes the API of Jenkins available for use in plugins. label Jan 4, 2020
@jglick
Copy link
Member Author

jglick commented Jan 4, 2020

@oleg-nenashev I am not sure why you added the plugin-api-changes label here; there are no (unrestricted) changes to accessible APIs.

@daniel-beck daniel-beck mentioned this pull request Jul 27, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-beck daniel-beck daniel-beck approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@res0nance res0nance res0nance approved these changes

Assignees
No one assigned
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
4 participants
@jglick @oleg-nenashev @daniel-beck @res0nance