[JENKINS-61321] Fix permission check

[daniel-beck]

See JENKINS-61321.

Well, f***.

Manually confirmed working. Needs Project-based Matrix Authorization, and a user with Job/Configure on the per-job level, rather than the global configuration.

Proposed changelog entries

• Do not disable all controls on job configuration forms for some users with Job/Configure permission. (regression in 2.223)

Proposed upgrade guidelines

N/A

Submitter checklist

• JIRA issue is well described
• Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• Appropriate autotests or explanation to why this change has no tests
• [n/a] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are correct
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a JIRA issue should exist and be labeled as lts-candidate

[timja]

🤕

[jvz]

[oleg-nenashev]

oops. We need to do more careful during the reviews. It is not the first time when we had such error, but the PR was fairly small and we should have caught it. OTOH low number of reports/votes suggests that the configuration-as-code/Pipeline-as-code adoption is going well

I plan to merge it tomorrow if no negative feedback.

[timja]

Manually confirmed working. Needs Project-based Matrix Authorization, and a user with Job/Configure on the per-job level, rather than the global configuration.

ugh I was just testing this for sanity, and was very confused when I couldn't re-produce this.

Well I'm not surprised I missed it when developing it =/