Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS 62750] Transform rss bar items into transparent buttons #4816

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

fqueiruga
Copy link
Contributor

@fqueiruga fqueiruga commented Jun 22, 2020

See JENKINS-62750.

This PR reworks the RSS bar to make the links transparent buttons. It also makes the items more accessible by combining the icons and text into a single link.
As a side effect, this PR also adds theming support for transparent buttons, thus opening core support for jenkinsci/dark-theme-plugin#105.

Screenshots

Home screen
Captura de pantalla 2020-06-22 a las 10 20 28

Log recorders
Captura de pantalla 2020-06-22 a las 20 04 50

Proposed changelog entries

  • Entry 1: JENKINS 62750, Restyling and improved accessibility for the RSS feed bar.
  • ...

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@timja

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Comment on lines +106 to +107
--btn-link-bg--hover: #f8f8f8;
--btn-link-bg--active: #eaeff2;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will enable theming support for the background

@timja timja self-requested a review June 22, 2020 13:40
@timja timja added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jun 22, 2020
@timja
Copy link
Member

timja commented Jun 22, 2020

Changes here look good, tested locally

Is the rss feed design intentionally not updating the log recorders page?

http://localhost:8080/jenkins/log/all

image

@fqueiruga
Copy link
Contributor Author

I wasn't aware of that page, do you think it's worth updating in the same way?

@timja
Copy link
Member

timja commented Jun 22, 2020

not sure if anyone even uses it tbh...

If it doesn't take long would be good to be consistent

@fqueiruga
Copy link
Contributor Author

Done, updated the screenshots

@timja timja requested a review from a team June 22, 2020 18:13
@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 22, 2020
@timja
Copy link
Member

timja commented Jun 22, 2020

Thanks for the PR!

This PR will be merged after 24 hours if there's no negative feedback

@timja timja merged commit 9176222 into jenkinsci:master Jun 24, 2020
@fqueiruga fqueiruga deleted the rss-bar-buttons branch August 5, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
5 participants