-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS 62750] Transform rss bar items into transparent buttons #4816
Conversation
--btn-link-bg--hover: #f8f8f8; | ||
--btn-link-bg--active: #eaeff2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will enable theming support for the background
Changes here look good, tested locally Is the rss feed design intentionally not updating the log recorders page? |
I wasn't aware of that page, do you think it's worth updating in the same way? |
not sure if anyone even uses it tbh... If it doesn't take long would be good to be consistent |
Done, updated the screenshots |
Thanks for the PR! This PR will be merged after 24 hours if there's no negative feedback |
See JENKINS-62750.
This PR reworks the RSS bar to make the links transparent buttons. It also makes the items more accessible by combining the icons and text into a single link.
As a side effect, this PR also adds theming support for transparent buttons, thus opening core support for jenkinsci/dark-theme-plugin#105.
Screenshots
Home screen
![Captura de pantalla 2020-06-22 a las 10 20 28](https://user-images.githubusercontent.com/5738588/85293961-5ad59280-b49e-11ea-9eb7-023de83a4edd.png)
Log recorders
![Captura de pantalla 2020-06-22 a las 20 04 50](https://user-images.githubusercontent.com/5738588/85320949-2bd21780-b4c4-11ea-8dd3-bb963560e91b.png)
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@timja
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).