Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 4.5 version of Remoting. #4831

Merged
merged 1 commit into from Jul 10, 2020
Merged

Conversation

jeffret-b
Copy link
Contributor

@jeffret-b jeffret-b commented Jul 6, 2020

Upgrade the Remoting (agent) jar from 4.3 to 4.5.

The only significant change here is that we now perform the release on the Jenkins release system and sign with the CDF certificate. This does not change any behavior.

The other changes in the 4.4 and 4.5 releases involve minor maintenance changes to improve ongoing maintainability. There is one minor logging improvement, which might help in some error situations.

See the Remoting changelogs: .

Proposed changelog entries

  • Upgrade to Remoting 4.5. This switches agent.jar and remoting.jar to a code-signing certificate owned by the CDF. Changelogs: 4.4 and 4.5

Proposed upgrade guidelines

N/A

Submitter checklist

  • [N/A] (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • [N/A] Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • [N/A] If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@jeffret-b jeffret-b requested a review from jvz July 6, 2020 16:49
@jeffret-b
Copy link
Contributor Author

Anyone know what label should be on this?

@timja timja added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted internal labels Jul 6, 2020
@timja
Copy link
Member

timja commented Jul 6, 2020

rfe I think, + changelogs should be directly linked in the changelog entry

@jeffret-b
Copy link
Contributor Author

Marking this as ready-for-merge as we have sufficient approvals. Let the time period begin.

@jeffret-b jeffret-b added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 8, 2020
@jeffret-b
Copy link
Contributor Author

This is ready to go now.

@timja timja merged commit 3fcc002 into jenkinsci:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
5 participants