Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JEP-227] Replace Acegi Security with Spring Security & upgrade Spring Framework #4848

Merged
merged 168 commits into from
Nov 6, 2020
Merged

[JEP-227] Replace Acegi Security with Spring Security & upgrade Spring Framework #4848

merged 168 commits into from
Nov 6, 2020

Commits on Jul 15, 2020

  1. Replacing Acegi Security with Spring Security

    @jglick
    jglick committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    2caf075 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. more

    @jglick
    jglick committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    82522cf View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2020

  1. Change of approach: completely deprecating org.acegisecurity types

    @jglick
    jglick committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    62eba9c View commit details
    Browse the repository at this point in the history

  2. More conversion

    @jglick
    jglick committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    0c02c44 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    d898b35 View commit details
    Browse the repository at this point in the history

  2. More

    @jglick
    jglick committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    f573052 View commit details
    Browse the repository at this point in the history

  3. Progress

    @jglick
    jglick committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    07412a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    0613a19 View commit details
    Browse the repository at this point in the history

  2. Seems that everything except uses of BeanBuilder now compiles

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    6af8f1c View commit details
    Browse the repository at this point in the history

  3. Rewrite BeanBuilder configuration of security to plain old Java

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    9111057 View commit details
    Browse the repository at this point in the history

  4. core module now at least compiles

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    6601d98 View commit details
    Browse the repository at this point in the history

  5. Starting to make tests compilable; will require changes to jenkins-te… 

    …st-harness
    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    b85c0d9 View commit details
    Browse the repository at this point in the history

  6. Tweaking AuthenticationProcessingFilter2

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    cfd9831 View commit details
    Browse the repository at this point in the history

  7. Comments

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    085f525 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    26060aa View commit details
    Browse the repository at this point in the history

  9. Merge branch 'support-log-formatter' into spring-5303

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    c6f0e12 View commit details
    Browse the repository at this point in the history

  10. Better logging for ChainedServletFilter

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    c3f9efd View commit details
    Browse the repository at this point in the history

  11. Can now log in; crumbs are broken though

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    a8a661e View commit details
    Browse the repository at this point in the history

  12. Searched more extensively for references to Acegi Security

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    76b0885 View commit details
    Browse the repository at this point in the history

  13. HttpSessionContextIntegrationFilter2 was critical after all; just too… 

    …k me a while to find that HttpSessionContextIntegrationFilter is now SecurityContextPersistenceFilter
    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    12598a7 View commit details
    Browse the repository at this point in the history

  14. Comment

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    a985a50 View commit details
    Browse the repository at this point in the history

  15. Fixing UserSeedProperty so that login works at last

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    4201baa View commit details
    Browse the repository at this point in the history

  16. Binary compatibility for QueueItemAuthenticator

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    a36f410 View commit details
    Browse the repository at this point in the history

  17. Fixing up QueueItemAuthenticator Javadoc

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    ae31edd View commit details
    Browse the repository at this point in the history

  18. Binary compatibility for SecurityRealm.AUTHENTICATED_AUTHORITY

    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    6434178 View commit details
    Browse the repository at this point in the history

  19. Binary compatibility for key methods of SecurityRealm and AbstractPas… 

    …swordBasedSecurityRealm
    @jglick
    jglick committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    da40e4a View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. Even trying to compile at this stage is a waste of CI resources

    @jglick
    jglick committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    1ed7887 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    3f163d8 View commit details
    Browse the repository at this point in the history

  3. Binary compatibility for User.impersonate and Jenkins.ANONYMOUS

    @jglick
    jglick committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    abb439d View commit details
    Browse the repository at this point in the history

  4. Binary compatibility for ACL.{SYSTEM,impersonate,as}

    @jglick
    jglick committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    100ca91 View commit details
    Browse the repository at this point in the history

  5. Tests compile

    @jglick
    jglick committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    58364c2 View commit details
    Browse the repository at this point in the history

  6. Giving up on subtyping relationships even for exceptions

    @jglick
    jglick committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    29e1b95 View commit details
    Browse the repository at this point in the history

  7. Implementing SecurityContext.to/fromSpring allows some functional tes… 

    …ts to pass
    @jglick
    jglick committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    0ad56da View commit details
    Browse the repository at this point in the history

  8. Do not want spring-jcl as it clashes with the commons-logging we bundle

    @jglick
    jglick committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    a4475c4 View commit details
    Browse the repository at this point in the history

  9. Some progress on tests using Authentication

    @jglick
    jglick committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    6dad321 View commit details
    Browse the repository at this point in the history

  10. org.acegisecurity.userdetails.User must be defined for JenkinsRule.Du… 

    …mmySecurityRealm to work
    @jglick
    jglick committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    62e73df View commit details
    Browse the repository at this point in the history

  11. Some tests are passing; may as well start trying CI

    @jglick
    jglick committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    998d673 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. @Wadeck helped me with TokenBasedRememberMeServices2

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    aa73f20 View commit details
    Browse the repository at this point in the history

  2. TokenBasedRememberMeServices2Test.rememberMeAutoLoginFailure was asse… 

    …rting some debug message removed in Spring Security
    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    d052fb8 View commit details
    Browse the repository at this point in the history

  3. Tracked down why WebClient.withBasicApiToken was not working in tests

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    1f14f3c View commit details
    Browse the repository at this point in the history

  4. Binary compatibility for CLICommand.{getTransportAuthentication,setTr… 

    …ansportAuth}
    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    044c42c View commit details
    Browse the repository at this point in the history

  5. ClassFilterImplSanityTest

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    0609eaf View commit details
    Browse the repository at this point in the history

  6. Rewrote Authentication.to/fromSpring, fixing two tests in QueueTest

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    5354321 View commit details
    Browse the repository at this point in the history

  7. Binary compatibility for Jenkins.getAuthentication

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    091d0ca View commit details
    Browse the repository at this point in the history

  8. Some more sanity checks around ACL.isAnonymous

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    11ec923 View commit details
    Browse the repository at this point in the history

  9. Binary compatibility for remaining ACL methods

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    4bdec83 View commit details
    Browse the repository at this point in the history

  10. Special round-trip handling for ACL.SYSTEM for compatibility

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    d8e6bea View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    84cb57b View commit details
    Browse the repository at this point in the history

  12. JobTest.readPermission failed because its @LocalData used a pre-jBCry… 

    …pt password hash
    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    cdf2e46 View commit details
    Browse the repository at this point in the history

  13. Binary compatibility for User.getUserDetailsForImpersonation

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    c95b476 View commit details
    Browse the repository at this point in the history

  14. Binary compatibility for SecurityListener

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    3910ebf View commit details
    Browse the repository at this point in the history

  15. ExtendedReadPermissionTest failed because its @LocalData used a pre-j… 

    …BCrypt password hash
    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    8a5bdf2 View commit details
    Browse the repository at this point in the history

  16. NPE in QueueItemAuthenticator

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    7ca54e4 View commit details
    Browse the repository at this point in the history

  17. LastGrantedAuthoritiesPropertyTest was reliant on the sort order of a… 

    …uthorities
    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    091bc23 View commit details
    Browse the repository at this point in the history

  18. StopBuildsCommandTest

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    43e8d29 View commit details
    Browse the repository at this point in the history

  19. Javadoc updates in TokenBasedRememberMeServices2

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    2aec3cb View commit details
    Browse the repository at this point in the history

  20. Accidentally removed code which added sessionSeed

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    4c7b6b3 View commit details
    Browse the repository at this point in the history

  21. makeTokenSignature can be called when a User is not yet in memory; ne… 

    …ed to force creation (authentication was already successful at this point)
    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    3a2d857 View commit details
    Browse the repository at this point in the history

  22. Also accidentally deleted some code necessary to handle disableRememb… 

    …erMe (SECURITY-996)
    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    736bca4 View commit details
    Browse the repository at this point in the history

  23. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    9902338 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. Rename refactoring missed a couple of overrides

    @jglick
    jglick committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    061e106 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    06d4b16 View commit details
    Browse the repository at this point in the history

  3. Binary compatibility for AccessControlled.hasPermission

    @jglick
    jglick committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    5adba3e View commit details
    Browse the repository at this point in the history

  4. Added back DataAccessResourceFailureException & DataRetrievalFailureE… 

    …xception
    @jglick
    jglick committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    a5d60e4 View commit details
    Browse the repository at this point in the history

  5. Binary compatibility for Queue.Item.authenticate and affiliated methods

    @jglick
    jglick committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    7fdb8db View commit details
    Browse the repository at this point in the history

  6. RememberMeServicesProxy is apparently unused by plugins, do not need … 

    …to care about compatibility
    @jglick
    jglick committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    54c65ed View commit details
    Browse the repository at this point in the history

  7. Javadoc fixes

    @jglick
    jglick committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    3094ae5 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    30b0079 View commit details
    Browse the repository at this point in the history

  9. Compilation error in test

    @jglick
    jglick committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    b1fcbc6 View commit details
    Browse the repository at this point in the history

  10. Incorrect code sample

    @jglick
    jglick committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    6d96228 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    f3e6c04 View commit details
    Browse the repository at this point in the history

  2. SecurityRealm.createFilter more legible with blocks

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    f69be2c View commit details
    Browse the repository at this point in the history

  3. Minor cleanups in TokenBasedRememberMeServices2

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    ecf3acc View commit details
    Browse the repository at this point in the history

  4. toSpring/fromSpring pattern for selected exception types

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    c382733 View commit details
    Browse the repository at this point in the history

  5. Apparently org.acegisecurity.Authentication.getAuthorities() could re… 

    …turn null
    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    4d7f00d View commit details
    Browse the repository at this point in the history

  6. NPE from SecurityContext

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    abf8251 View commit details
    Browse the repository at this point in the history

  7. Added back AbstractAuthenticationToken (supertype e.g. of GithubAuthe… 

    …nticationToken)
    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    7c5ce69 View commit details
    Browse the repository at this point in the history

  8. Binary compatibility for SecurityComponents

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    0ae2aaa View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    bd53bea View commit details
    Browse the repository at this point in the history

  10. Test compilation error

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    034ecff View commit details
    Browse the repository at this point in the history

  11. Run japicmp

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    b11f3e4 View commit details
    Browse the repository at this point in the history

  12. Binary compatibility for Items.all and .allItems

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    f32ed4f View commit details
    Browse the repository at this point in the history

  13. Binary compatibility for User.get

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    232194d View commit details
    Browse the repository at this point in the history

  14. Binary compatibility for ACL.isAnonymous

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    530455c View commit details
    Browse the repository at this point in the history

  15. Binary compatibility for ACLContext.getPreviousContext

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    545e347 View commit details
    Browse the repository at this point in the history

  16. Adding @restricted(NoExternalUse.class) to a couple of classes which … 

    …never seem to have been used from plugins
    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    e27ec10 View commit details
    Browse the repository at this point in the history

  17. Binary compatibility for SecurityRealm.getPostLogOutUrl

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    0a32650 View commit details
    Browse the repository at this point in the history

  18. ImpersonatingUserDetailsService does not seem to have ever been used … 

    …from plugins
    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    c9662fb View commit details
    Browse the repository at this point in the history

  19. Binary compatibility for ImpersonatingExecutorService and Impersonati… 

    …ngScheduledExecutorService constructors
    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    19cb4ad View commit details
    Browse the repository at this point in the history

  20. Binary compatibility for LastGrantedAuthoritiesProperty.getAuthorities

    @jglick
    jglick committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    f49afdf View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Wrong access modifier for AbstractPasswordBasedSecurityRealm.authenti… 

    …cate
    @jglick
    jglick committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    09feb27 View commit details
    Browse the repository at this point in the history

  2. SecurityRealm.findBean was only used in conjunction with BeanBuilder

    @jglick
    jglick committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    b7f1acc View commit details
    Browse the repository at this point in the history

  3. Javadoc error

    @jglick
    jglick committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    340e0f9 View commit details
    Browse the repository at this point in the history

  4. NPE from User.get

    @jglick
    jglick committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    d0a125a View commit details
    Browse the repository at this point in the history

  5. Need to implement setDetails in former subtypes of AbstractAuthentica… 

    …tionToken
    @jglick
    jglick committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    697e555 View commit details
    Browse the repository at this point in the history

  6. Custom subtypes of UserDetails must be round-tripped

    @jglick
    jglick committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    ffdf039 View commit details
    Browse the repository at this point in the history

  7. Need to translate UserDetails values for Authentication.principal

    @jglick
    jglick committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    a175d17 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Align User.serialVersionUID with the Acegi Security version

    @jglick
    jglick committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    a73186b View commit details
    Browse the repository at this point in the history

  2. Deprecated stub for WebAuthenticationDetails

    @jglick
    jglick committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    8711c7b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    28ddf31 View commit details
    Browse the repository at this point in the history

  4. Added AuthenticationProvider & AbstractUserDetailsAuthenticationProvider

    @jglick
    jglick committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    d545242 View commit details
    Browse the repository at this point in the history

  5. Adding FieldUtils, used by tests in a few plugins

    @jglick
    jglick committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    2f3a61e View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. Binary compatibility for PrincipalSid and GrantedAuthoritySid constru… 

    …ctors
    @jglick
    jglick committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    f77173c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    1abe5c6 View commit details
    Browse the repository at this point in the history

  3. Restoring some methods in AuthenticationException, called from Abstra… 

    …ctAuthenticationManager in LDAPAuthenticationManager
    @jglick
    jglick committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    6851e32 View commit details
    Browse the repository at this point in the history

  4. Restoring serial form compatibility for GrantedAuthorityImpl

    @jglick
    jglick committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    4731952 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    e90cfa4 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. Restored SecurityContextImpl

    @jglick
    jglick committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    50a470f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    1ebb6a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. To avoid Java serialization issues, HudsonPrivateSecurityRealm.Detail… 

    …s no longer implements UserDetails
    @jglick
    jglick committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    a67b028 View commit details
    Browse the repository at this point in the history

  2. Update detached ldap to compatible version from jenkinsci/ldap-plugin#48

    @jglick
    jglick committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    d94651e View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. AccessDeniedException2Test → AccessDeniedException3Test

    @jglick
    jglick committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    8f71d91 View commit details
    Browse the repository at this point in the history

  2. Ensure ExceptionTranslationFilter still works if a plugin throws Acce… 

    …ssDeniedException2
    @jglick
    jglick committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    7a063db View commit details
    Browse the repository at this point in the history

  3. Binary compatibility for BasicHeaderAuthenticator

    @jglick
    jglick committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    1e41d5a View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    cc029a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    7b87b21 View commit details
    Browse the repository at this point in the history

  2. Restored AuthenticationServiceException

    @jglick
    jglick committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    b380b78 View commit details
    Browse the repository at this point in the history

  3. Binary compatibility for HudsonPrivateSecurityRealm.Details.getAuthor… 

    …ities
    @jglick
    jglick committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    64f820e View commit details
    Browse the repository at this point in the history

  4. Restored User.setAuthorities

    @jglick
    jglick committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    b7ed635 View commit details
    Browse the repository at this point in the history

  5. To be useful from ActiveDirectoryUserDetail, overridable setAuthoriti… 

    …es needs to be called from the ctor (yes this is an antipattern)
    @jglick
    jglick committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    5711c49 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. INFRA-266 Adjust test for plugins over https

    @timja
    timja committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    7befcfd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    80bcc26 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'UpdateCenter2Test.install' into spring-5303

    @jglick
    jglick committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    a878549 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fix-test' of github.com:timja/jenkins into spring-5303

    @jglick
    jglick committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    4845972 View commit details
    Browse the repository at this point in the history

  5. Round-tripping SecurityRealm.AUTHENTICATED_AUTHORITY as object identi… 

    …ty: https://github.com/jenkinsci/saml-plugin/blob/351a0210a31c2368b5630c91316afe8bee3b0f5f/src/main/java/org/jenkinsci/plugins/saml/SamlUserDetailsService.java#L62
    @jglick
    jglick committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    e2b6ff9 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    1a90114 View commit details
    Browse the repository at this point in the history

  2. Catching and translating AuthenticationException & AcegiSecurityExcep… 

    …tion more broadly.

Should improve compatibility for code like: https://github.com/jenkinsci/matrix-auth-plugin/blob/9616b3877395aa1e8b0b403601a968fa7a461193/src/main/java/org/jenkinsci/plugins/matrixauth/AuthorizationContainerDescriptor.java#L139-L167
    @jglick
    jglick committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    929dcd3 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. https://github.com/spring-projects/spring-security/releases/tag/5.3.4… 

    ….RELEASE
    @jglick
    jglick committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    5f119f5 View commit details
    Browse the repository at this point in the history

  2. Use JUnit 5

    @jglick
    jglick committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    2f6380c View commit details
    Browse the repository at this point in the history

  3. While UsernameNotFoundException extends BadCredentialsException in Ac… 

    …egi Security, in Spring Security it directly extends AuthenticationException
    @jglick
    jglick committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    fe269a9 View commit details
    Browse the repository at this point in the history

  4. Documenting that Run.fromExternalizableId can throw AccessDeniedExcep… 

    …tion
    @jglick
    jglick committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    5d87079 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    4eaf883 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. AbstractAuthenticationToken should be @deprecated 

    Co-authored-by: James Nord <jtnord@users.noreply.github.com>
    @jglick @jtnord
    jglick and jtnord committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    17a7fcb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    b7d7d89 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Apparently the ~2h of functional tests do not include the corner case… 

    … that you mistyped your password
    @jglick
    jglick committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    fd744d2 View commit details
    Browse the repository at this point in the history

  2. Reverting unintentional Javadoc change

    @jglick
    jglick committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    7fa8a12 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    2be2146 View commit details
    Browse the repository at this point in the history

  2. Round-trip org.acegisecurity.Authentication, making LdapMultiEmbedded… 

    …2Test.login pass in PCT
    @jglick
    jglick committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    657338c View commit details
    Browse the repository at this point in the history

  3. Round-trip DataAccessException, for PCT in LdapMultiEmbeddedTest

    @jglick
    jglick committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    4bb45a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    862e4e5 View commit details
    Browse the repository at this point in the history

  2. Bumping detached copy of ldap, for now to the release of jenkinsci/ld… 

    …ap-plugin#48
    @jglick
    jglick committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    2bf6185 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    5b60ed0 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. org.acegisecurity.ui.remember → org.acegisecurity.ui.rememberme

    @jglick
    jglick committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    c020f8a View commit details
    Browse the repository at this point in the history

  2. TokenBasedRememberMeServices2 is not intended as an API

    @jglick
    jglick committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    ba608c3 View commit details
    Browse the repository at this point in the history

  3. UserDetailsSpringImpl can be marked deprecated to avoid warnings abou… 

    …t references
    @jglick
    jglick committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    dc589f1 View commit details
    Browse the repository at this point in the history

  4. Round-trip RememberMeServices subtypes, expected by crowd2

    @jglick
    jglick committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    1039b2b View commit details
    Browse the repository at this point in the history

  5. TokenBasedRememberMeServices placeholder for CrowdServletFilter

    @jglick
    jglick committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    419e44e View commit details
    Browse the repository at this point in the history

  6. crowd2 uses AccountExpiredException, CredentialsExpiredException, & I… 

    …nsufficientAuthenticationException
    @jglick
    jglick committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    950666e View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    14f2074 View commit details
    Browse the repository at this point in the history

  2. https://github.com/spring-projects/spring-security/releases/tag/5.4.0

    @jglick
    jglick committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    df3ca87 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    e69a339 View commit details
    Browse the repository at this point in the history

  2. Handle calls to super.getPostLogOutUrl without StackOverflowError

    @jglick
    jglick committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    b6d5a6e View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    4bed0db View commit details
    Browse the repository at this point in the history

  2. Compatibility for ProviderNotFoundException

    @jglick
    jglick committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    6548efe View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    eb4e22d View commit details
    Browse the repository at this point in the history

  2. Binary compatibility for ImpersonatingUserDetailsService, used by at … 

    …least https://github.com/apefactory/cloudfoundry-uaa-oauth
    @jglick
    jglick committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    df7c2e9 View commit details
    Browse the repository at this point in the history

  3. Restoring SecurityRealm.createCliAuthenticator to minimize disruption

    @jglick
    jglick committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    83e4fe9 View commit details
    Browse the repository at this point in the history

  4. Restricted a lot of APIs which should not be used in plugins. 

    Gathered this list by looking at incompatible changes in japicmp.
Most are in fact unused; collabnet plugin uses many, but seems to be a blind copy-paste from core.
ExceptionTranslationFilter now merely extended the Spring version, so may as well delete.
    @jglick
    jglick committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    da3d17b View commit details
    Browse the repository at this point in the history

  5. Suppress some doclint as in jenkinsci/plugin-pom#356

    @jglick
    jglick committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    7ff3ff5 View commit details
    Browse the repository at this point in the history

  6. Broken Javadoc reference after da3d17b

    @jglick
    jglick committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    7646dfd View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Merge branch 'master' of github.com:jenkinsci/jenkins into spring-5303

    @jglick
    jglick committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    d2ae6ca View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Merge branch 'master' of https://github.com/jenkinsci/jenkins into sp… 

    …ring-5303
    @jglick
    jglick committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    3e3792d View commit details
    Browse the repository at this point in the history

  2. https://github.com/spring-projects/spring-security/releases/tag/5.4.1

    @jglick
    jglick committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    3ce4ca3 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. Merge branch 'master' of https://github.com/jenkinsci/jenkins into sp… 

    …ring-5303
    @jglick
    jglick committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    899773e View commit details
    Browse the repository at this point in the history

  2. DisabledException & LockedException referenced from https://github.co… 

    …m/jenkinsci/cas-plugin/blob/d17aa8583af17dfdb8e069c41f986f2d844a719c/src/main/java/org/jenkinsci/plugins/cas/spring/security/AcegiAuthenticationManager.java#L53-L56
    @jglick
    jglick committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    757e1a7 View commit details
    Browse the repository at this point in the history

  3. HttpSessionContextIntegrationFilter2 is used by cas and collabnet plu… 

    …gins.

Unrestricting it will not allow versions built on Acegi Security to work, since its signature is changing,
but will at least allow newer versions rewritten to Spring Security to retain this functionality.
Ideally there would be some more opaque mechanism to make more pieces of SecurityRealm.createFilter reusable
(this one is not in commonFilters shared with LegacySecurityRealm).
    @jglick
    jglick committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    ffe273a View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Merge branch 'master' of https://github.com/jenkinsci/jenkins into sp… 

    …ring-5303
    @jglick
    jglick committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    a829508 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2020

  1. Merge branch 'master' into spring-5303

    @timja
    timja committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    f04114c View commit details
    Browse the repository at this point in the history