Normalize colors to the palette #4867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Merges the --lightest-grey into --very-light-grey, with a value of #f8f8f8 (as in the color palette) - Removes some hardcoded, off-palette greys on several resource files - Brings to palette colors on buildHistory widget, plugin excerpts - Removes unused CSS variables - Changes default icon fill to --text-color - Applies the .bigtable style to the Matrix Project tables
daniel-beck
reviewed
Jul 24, 2020
oleg-nenashev
added
rfe
timja
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
All seems fine,
It doesn't appear to fix jenkinsci/dark-theme-plugin#126 as reported that it does though.
|
@timja should work now |
confirmed, works, thanks! |
oleg-nenashev
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
Sounds about right.
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process
oleg-nenashev
added
the
ready-for-merge
timja
added
bug
olivergondza
pushed a commit
to olivergondza/jenkins
that referenced
this pull request
Aug 25, 2020
(cherry picked from commit 87f9404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normalizes many colors used in Jenkins to the new palette used in the sidebar, hyperlinks, buttons, tables, etc.
Changes:
--primaryand--primary-hovervariables to reflect their actual use. The current primary hover color was used as primary on the first iterations of the palette--lightest-greyinto--very-light-grey, with a value of #f8f8f8 (as in the color palette)--text-color..bigtablestyles applied to the Matrix Project tables.Some screenshots
Matrix project table using
.bigtablestyles for coherencePlugin uninstall warning using proper colors
Note: this PR intentionally leaves out many hardcoded values due to difficulty of changing the values or testing the changes. On example is the progress bar. If the proper
--primaryand--dangervalues are used in the progress bar it will still look weird because the fill animation is done using a gif.Fixes #4867
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@timja
@uhafner
@oleg-nenashev
@daniel-beck
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).