Upgrade jQuery to 3.5.x #4929

fqueiruga · 2020-09-10T08:57:29Z

This PR bumps the jQuery version from 2.1.4 to 3.5.x.
I have created the PR in order to properly test it with a CI build.

JS changes:

Remove uses of the .size() and .load() methods
Remove the unit tests on the maven test command because they have not been ported

Testing command:

docker run --rm -it -p 8080:8080 -e ID=4929 jenkins/core-pr-tester

Proposed changelog entries

TBD

Proposed upgrade guidelines

N/A

Submitter checklist

(If applicable) Jira issue is well described
Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
- Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
Appropriate autotests or explanation to why this change has no tests
For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@uhafner
@Wadeck
@timja

Maintainer checklist

Before the changes are marked as ready-for-merge:

There are at least 2 approvals for the pull request and no outstanding requests for change
Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
Changelog entries in the PR title and/or Proposed changelog entries are correct
Proper changelog labels are set so that the changelog can be generated automatically
If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

- Remove uses of the .size() and .load() methods - Remove the unit tests on the maven test command because they have not been ported

fqueiruga

Taking this one out of WIP status as the proper work is done but there are some discussions and some work left.

Most of the JS unit tests do not work with this PR. These tests are very difficult to migrate and offer little value, as most of the use-cases they cover are also covered by JTH and ATH suites. Any thoughts on this?

timja

are you running ATH over this? (more than just the default smoke tests that run on CI)

Most of the JS unit tests do not work with this PR. These tests are very difficult to migrate and offer little value, as most of the use-cases they cover are also covered by JTH and ATH suites. Any thoughts on this?

Can probably remove.

fqueiruga · 2020-10-05T15:21:04Z

I'll get back to you with a full ATH run hopefully tomorrow

fqueiruga · 2020-10-06T08:17:11Z

I have verified that there are no ATH errors that don't happen in other PRs.

Wadeck

Random manual testing (like monkey typing on keyboards), looking for console errors. Core (without plugins) was working fine, testing with multiple pages.

uhafner

Nice! This PR makes my jQuery plugin obsolete (if this PR is part of an LTS). Is jQuery 3.x then available as $ in views or do we still need workarounds? (How does this change relate to https://github.com/jenkinsci/jquery-plugin? Is this plugin then obsolete as well?)

romenrg

Just ran some manual smoke tests, clicking random stuff and checking both behavior and the inspect console, as Wadeck did; and everything looks good to me.

fqueiruga · 2020-10-06T12:05:35Z

Nice! This PR makes my jQuery plugin obsolete (if this PR is part of an LTS). Is jQuery 3.x then available as $ in views or do we still need workarounds? (How does this change relate to https://github.com/jenkinsci/jquery-plugin? Is this plugin then obsolete as well?)

It is not. Plugins are still needed for their intended use case. The jQuery version in core is contained to the bundles generated by webpack and not exposed to the window namespace. It should have no effect in any plugin (except those that hook up to the setup wizard).

fqueiruga · 2020-10-06T12:07:25Z

For context, $ in vanilla jenkins (no plugins) corresponds to the prototype object, not jquery

fqueiruga · 2020-10-06T13:52:53Z

I have run a comprehensive PCT suite and have found some errors that I need to go through. I suspect is due to outdated POMs but still, I'd like to have the PR marked as on hold maybe after the LTS selection.

timja · 2020-10-23T19:47:47Z

I have run a comprehensive PCT suite and have found some errors that I need to go through. I suspect is due to outdated POMs but still, I'd like to have the PR marked as on hold maybe after the LTS selection.

@fqueiruga should unhold be removed now?

fqueiruga · 2020-10-24T11:59:19Z

TBH I would like to give it a few weeklies of margin, maybe get it in 2.266 or 2.267. The reason is that I don't want the bug reports arising from tables-to-divs to be muddied by this PR, if that makes sense.

timja · 2020-11-08T15:51:14Z

thoughts on shipping in 2.266?

MarkEWaite · 2020-11-08T16:26:47Z

thoughts on shipping in 2.266?

I've mentioned that this change is coming in a proposed blog post inviting users and administrators to assist with testing Jenkins weekly releases. I think that including it in Jenkins 2.266 does not complicate bug triage any more than it is already.

fqueiruga · 2020-11-08T20:15:06Z

Let's go then!

timja · 2020-11-08T20:43:55Z

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

oleg-nenashev

It is a bit YOLO, but we should merge it sooner or later. I vote for merging sooner, we have only 1 month before the Christmas break so extra week is a good addition for user feedback

liuweiGL · 2020-11-12T06:25:54Z

I think this is a break change? My plugin stopped working.

link: https://github.com/jenkinsci/dingtalk-plugin/blob/ca8695a276d3e2258b363f6f35a48573e3e6db14/src/main/webapp/scripts/customValidate.js#L9

fqueiruga · 2020-11-12T09:59:35Z

@liuweiGL can you comment this on the issue? From what I see, your plugin is no loading jQuery in package.json, or in POM.xml. This change was also scoped to just Jenkinsci and should have no sideffects on other plugins.

From what I see, that $ variable may be referring to the prototypejs instance that Jenkins provides. jQuery does not provide a .up() method, but prototype does http://api.prototypejs.org/dom/Element/up/

fqueiruga · 2020-11-12T10:17:03Z

@liuweiGL I think your plugin may have broken on the tables-to-divs release on Jenkins 2.264, given that the change is to DOM transversal on a form function. You could report the issue on the appropiate epic https://issues.jenkins.io/browse/JENKINS-62437 and tag the issue with the label tables-to-divs-regression. More information on how to fix the plugin on https://www.jenkins.io/blog/2020/11/10/major-changes-in-weekly-releases/#plugin-developers

liuweiGL · 2020-11-12T13:09:50Z

Thank you very much.

Upgrades jQuery to v 3.5.x for security

ed9f7f4

- Remove uses of the .size() and .load() methods - Remove the unit tests on the maven test command because they have not been ported

fqueiruga marked this pull request as draft September 10, 2020 08:57

fqueiruga added 2 commits September 30, 2020 12:53

Merge branch 'master' into test-jquery-upgrade-to-3.5

11c0f50

Merge branch 'master' into test-jquery-upgrade-to-3.5

c456562

fqueiruga changed the title ~~[WIP] upgrade jQuery to 3.5.x~~ Upgrade jQuery to 3.5.x Oct 5, 2020

fqueiruga marked this pull request as ready for review October 5, 2020 14:45

fqueiruga commented Oct 5, 2020

View reviewed changes

fqueiruga added 2 commits October 5, 2020 16:51

Manually trigger a repaint on job forms

0ed6bcc

Remove low-value broken tests

58dd9da

timja reviewed Oct 5, 2020

View reviewed changes

timja approved these changes Oct 6, 2020

View reviewed changes

timja requested a review from uhafner October 6, 2020 09:28

timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Oct 6, 2020

Wadeck approved these changes Oct 6, 2020

View reviewed changes

timja requested a review from romenrg October 6, 2020 10:02

uhafner approved these changes Oct 6, 2020

View reviewed changes

romenrg approved these changes Oct 6, 2020

View reviewed changes

timja added on-hold This pull request depends on another event/release, and it cannot be merged right now squash-merge-me Unclean or useless commit history, should be merged only with squash-merge labels Oct 6, 2020

res0nance approved these changes Oct 27, 2020

View reviewed changes

timja added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed on-hold This pull request depends on another event/release, and it cannot be merged right now labels Nov 8, 2020

oleg-nenashev approved these changes Nov 9, 2020

View reviewed changes

timja merged commit 98ab202 into jenkinsci:master Nov 9, 2020

fqueiruga mentioned this pull request Dec 11, 2020

Remove traces from jquery-detached from core #5107

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade jQuery to 3.5.x #4929

Upgrade jQuery to 3.5.x #4929

fqueiruga commented Sep 10, 2020 •

edited by Wadeck

fqueiruga left a comment

timja left a comment •

edited

fqueiruga commented Oct 5, 2020

fqueiruga commented Oct 6, 2020 •

edited

Wadeck left a comment

uhafner left a comment

romenrg left a comment

fqueiruga commented Oct 6, 2020 •

edited

fqueiruga commented Oct 6, 2020

fqueiruga commented Oct 6, 2020

timja commented Oct 23, 2020

fqueiruga commented Oct 24, 2020

timja commented Nov 8, 2020

MarkEWaite commented Nov 8, 2020

fqueiruga commented Nov 8, 2020

timja commented Nov 8, 2020

oleg-nenashev left a comment

liuweiGL commented Nov 12, 2020

fqueiruga commented Nov 12, 2020

fqueiruga commented Nov 12, 2020

liuweiGL commented Nov 12, 2020

Upgrade jQuery to 3.5.x #4929

Upgrade jQuery to 3.5.x #4929

Conversation

fqueiruga commented Sep 10, 2020 • edited by Wadeck

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

fqueiruga left a comment

Choose a reason for hiding this comment

timja left a comment • edited

Choose a reason for hiding this comment

fqueiruga commented Oct 5, 2020

fqueiruga commented Oct 6, 2020 • edited

Wadeck left a comment

Choose a reason for hiding this comment

uhafner left a comment

Choose a reason for hiding this comment

romenrg left a comment

Choose a reason for hiding this comment

fqueiruga commented Oct 6, 2020 • edited

fqueiruga commented Oct 6, 2020

fqueiruga commented Oct 6, 2020

timja commented Oct 23, 2020

fqueiruga commented Oct 24, 2020

timja commented Nov 8, 2020

MarkEWaite commented Nov 8, 2020

fqueiruga commented Nov 8, 2020

timja commented Nov 8, 2020

oleg-nenashev left a comment

Choose a reason for hiding this comment

liuweiGL commented Nov 12, 2020

fqueiruga commented Nov 12, 2020

fqueiruga commented Nov 12, 2020

liuweiGL commented Nov 12, 2020

fqueiruga commented Sep 10, 2020 •

edited by Wadeck

timja left a comment •

edited

fqueiruga commented Oct 6, 2020 •

edited

fqueiruga commented Oct 6, 2020 •

edited