Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-53720] is fixed already with spotbugs version update #5097

Merged
merged 1 commit into from Dec 10, 2020

Conversation

StefanSpieker
Copy link
Contributor

The java 11 and spotbugs related bug was already fixed with a recent spotbugs update. It was actually fixed with spotbugs/spotbugs#1248
See JENKINS-53720.

Proposed changelog entries

  • Internal: Removed rule from spotbugs exclude file, because issue was fixed within SpotBugs

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@res0nance res0nance added internal skip-changelog Should not be shown in the changelog labels Dec 7, 2020
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 8, 2020
@timja
Copy link
Member

timja commented Dec 8, 2020

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@res0nance res0nance merged commit 53f300d into jenkinsci:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
4 participants