[JENKINS-64390] make FieldUtils behave as it used to #5105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
commented
Dec 9, 2020
| assertThrows(Exception.class, () -> FieldUtils.setProtectedFieldValue("bogus", sut, "whatever")); | ||
| } | ||
|
|
||
| class InnerClassWithPublicFinalField { |
There was a problem hiding this comment.
this behaved differently with the initial acegi-rewrite if it was public
6 tasks
jglick
approved these changes
Dec 9, 2020
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
res0nance
approved these changes
Dec 9, 2020
jtnord
added
the
ready-for-merge
oleg-nenashev
approved these changes
Dec 10, 2020
| @@ -40,8 +42,14 @@ public static Object getProtectedFieldValue(String protectedField, Object object | |||
|
|
|||
| public static void setProtectedFieldValue(String protectedField, Object object, Object newValue) { | |||
| try { | |||
| org.apache.commons.lang.reflect.FieldUtils.writeField(object, protectedField, newValue, true); | |||
| } catch (IllegalAccessException x) { | |||
| // acgegi would silently fail to write to final fields | |||
There was a problem hiding this comment.
Suggested change
| // acgegi would silently fail to write to final fields | |
| // acegi would silently fail to write to final fields |
Well the whole class is deprecated, so the sole criterion is compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acegi FieldUtils used to silently fail when you tried to set a field that was both
publicandfinalWhilst it seems silly to do that (the code was obviously a no-op) I observed a breakage in a plugin (test code) that was doing exactly that. seems like there is a possibility that some production code may exist that also was doing this that would now be broken, so make the code also silently fail for that case.
See JENKINS-64390.
Proposed changelog entries
FieldUtilsnow silently fails to setpublic finalfields again.Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@jglick
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).