Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump groovy-all from 2.4.12 to 2.4.21 #5116

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 14, 2020

Bumps groovy-all from 2.4.12 to 2.4.21.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [groovy-all](https://github.com/apache/groovy) from 2.4.12 to 2.4.21.
- [Release notes](https://github.com/apache/groovy/releases)
- [Commits](https://github.com/apache/groovy/commits)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Dec 14, 2020
@jglick
Copy link
Member

jglick commented Dec 14, 2020

Possibly OK, though requires thorough testing against Script Security and Pipeline. See #5112 for context. CC @dwnusbaum

@dwnusbaum
Copy link
Member

dwnusbaum commented Dec 14, 2020

Possibly OK, though requires thorough testing against Script Security and Pipeline

Yeah, at the minimum I would want to see linked PRs against workflow-cps, workflow-job, and pipeline-model-definition as well as a simultaneous PR to groovy-sandbox and groovy-cps to verify existing tests, and then someone needs to go through release notes and/or commits to look for changes that might be problematic for security or performance in Jenkins. Ideally we would also do some performance comparisons using https://github.com/cloudbees/jenkins-scalability-lab or something like it.

@batmat
Copy link
Member

batmat commented Dec 14, 2020

Would you recommend we actually tell Dependabot to ignore and not file updates for this dependency? From what you're saying, I'd think yes. I would not want a future update going through more freely because you two are on vacation or whatever? :-)

@jglick
Copy link
Member

jglick commented Dec 14, 2020

Certainly Groovy should be excluded from Dependabot updates.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 16, 2020

Looks like org.codehaus.groovy:groovy-all is no longer being updated by Dependabot, so this is no longer needed.

@dependabot dependabot bot closed this Dec 16, 2020
@dependabot dependabot bot deleted the dependabot/maven/org.codehaus.groovy-groovy-all-2.4.21 branch December 16, 2020 21:04
@daniel-beck daniel-beck mentioned this pull request Mar 5, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
3 participants