[JENKINS-64746] public API hudson.model.UpdateCenter.HudsonUpgradeJob constructor signature change #5216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
added
the
bug
6 tasks
jtnord
reviewed
Jan 29, 2021
rsandell
approved these changes
Jan 29, 2021
jtnord
approved these changes
Jan 29, 2021
jtnord
added
the
ready-for-merge
jglick
approved these changes
Jan 29, 2021
| @@ -2111,6 +2111,15 @@ public InstallationJob(Plugin plugin, UpdateSite site, Authentication auth) { | |||
| this(plugin,site,auth,false); | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated use {@code InstallationJob(Plugin, UpdateSite, Authentication, boolean)} | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated use {@code InstallationJob(Plugin, UpdateSite, Authentication, boolean)} | |
| * @deprecated use {@link #InstallationJob(Plugin, UpdateSite, Authentication, boolean)} |
| @@ -2111,6 +2111,15 @@ public InstallationJob(Plugin plugin, UpdateSite site, Authentication auth) { | |||
| this(plugin,site,auth,false); | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated use {@code InstallationJob(Plugin, UpdateSite, Authentication, boolean)} | |||
| * @see #InstallationJob(Plugin, UpdateSite, Authentication, boolean) | |||
There was a problem hiding this comment.
Suggested change
| * @see #InstallationJob(Plugin, UpdateSite, Authentication, boolean) |
Comment on lines
2339
to
2340
| * @deprecated use {@code PluginDowngradeJob(Plugin, UpdateSite, Authentication)} | ||
| * @see #PluginDowngradeJob(Plugin, UpdateSite, Authentication) |
Comment on lines
2434
to
2435
| * @deprecated use {@code HudsonUpgradeJob(UpdateSite site, Authentication auth)} | ||
| * @see #HudsonUpgradeJob(UpdateSite, Authentication) |
Comment on lines
2478
to
2479
| * @deprecated use {@code HudsonDowngradeJob(UpdateSite site, Authentication auth)} | ||
| * @see #HudsonDowngradeJob(UpdateSite, Authentication) |
jtnord
approved these changes
Jan 29, 2021
jtnord
approved these changes
Jan 29, 2021
jglick
reviewed
Jan 29, 2021
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
|
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process |
jglick
reviewed
Jan 30, 2021
| public InstallationJob(Plugin plugin, UpdateSite site, org.acegisecurity.Authentication auth, boolean dynamicLoad) { | ||
| this(plugin, site, auth.toSpring(), dynamicLoad); | ||
| } | ||
|
|
||
| public InstallationJob(Plugin plugin, UpdateSite site, Authentication auth, boolean dynamicLoad) { |
There was a problem hiding this comment.
Would also be polite to add @since 2.266 for the Spring overloads.
| @@ -2410,6 +2427,15 @@ public String toString() { | |||
| * Represents the state of the upgrade activity of Jenkins core. | |||
| */ | |||
| public final class HudsonUpgradeJob extends DownloadJob { | |||
|
|
|||
| /** | |||
| * @deprecated use {@link HudsonUpgradeJob(UpdateSite site, Authentication auth)} | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated use {@link HudsonUpgradeJob(UpdateSite site, Authentication auth)} | |
| * @deprecated use {@link HudsonUpgradeJob(UpdateSite, Authentication)} |
How is this not a build failure? Hmm…
| @@ -2444,6 +2470,15 @@ protected void replace(File dst, File src) throws IOException { | |||
| } | |||
|
|
|||
| public final class HudsonDowngradeJob extends DownloadJob { | |||
|
|
|||
| /** | |||
| * @deprecated use {@link HudsonDowngradeJob(UpdateSite site, Authentication auth)} | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated use {@link HudsonDowngradeJob(UpdateSite site, Authentication auth)} | |
| * @deprecated use {@link HudsonDowngradeJob(UpdateSite, Authentication)} |
| @@ -30,6 +30,7 @@ | |||
| import java.util.Map; | |||
| import java.util.UUID; | |||
|
|
|||
| import hudson.security.ACL; | |||
There was a problem hiding this comment.
Suggested change
| import hudson.security.ACL; |
timja
pushed a commit
to timja/jenkins
that referenced
this pull request
Feb 17, 2021
… constructor signature change (jenkinsci#5216) Co-authored-by: Jesse Glick <jglick@cloudbees.com> (cherry picked from commit 2c1e839)
timja
pushed a commit
to timja/jenkins
that referenced
this pull request
Feb 17, 2021
… constructor signature change (jenkinsci#5216) Co-authored-by: Jesse Glick <jglick@cloudbees.com> (cherry picked from commit 2c1e839)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-64746.
The breaking change was introduced by #4848
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@jglick
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).