[JENKINS-55582] Split instance-identity to a plugin #5304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvz
approved these changes
Feb 23, 2021
jglick
commented
Feb 23, 2021
| bouncycastle-api command-launcher | ||
| trilead-api instance-identity | ||
| jdk-tool instance-identity | ||
| bouncycastle-api jdk-tool |
There was a problem hiding this comment.
Trial-and-error.
I still get errors during the setup wizard because ssh-credentials cannot be installed without updating trilead-api. Not sure if that is somehow related to this PR.
There was a problem hiding this comment.
yes, sshd PR worked fine through setup wizard.
Appears to be related to this PR
Also I get this on a clean install on startup:
2021-02-25 21:13:53.773+0000 [id=42] WARNING h.ExtensionFinder$GuiceFinder$SezpozModule#configure: Failed to load org.jenkinsci.modules.systemd_slave_installer.SlaveInstallerFactoryImpl
java.lang.ClassNotFoundException: org.jenkinsci.main.modules.instance_identity.InstanceIdentity
at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:471)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:589)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:538)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
Caused: java.lang.NoClassDefFoundError: Lorg/jenkinsci/main/modules/instance_identity/InstanceIdentity;
at java.base/java.lang.Class.getDeclaredFields0(Native Method)
at java.base/java.lang.Class.privateGetDeclaredFields(Class.java:3061)
at java.base/java.lang.Class.getDeclaredFields(Class.java:2248)
at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:497)
at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:482)
at hudson.ExtensionFinder$GuiceFinder$SezpozModule.configure(ExtensionFinder.java:525)
at com.google.inject.AbstractModule.configure(AbstractModule.java:62)
at com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:340)
at com.google.inject.spi.Elements.getElements(Elements.java:110)
at com.google.inject.internal.InjectorShell$Builder.build(InjectorShell.java:138)
at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:104)
at com.google.inject.Guice.createInjector(Guice.java:96)
at com.google.inject.Guice.createInjector(Guice.java:73)
at hudson.ExtensionFinder$GuiceFinder.<init>(ExtensionFinder.java:285)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
at java.base/java.lang.Class.newInstance(Class.java:584)
at net.java.sezpoz.IndexItem.instance(IndexItem.java:181)
at hudson.ExtensionFinder$Sezpoz._find(ExtensionFinder.java:703)
at hudson.ExtensionFinder$Sezpoz.find(ExtensionFinder.java:689)
at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:349)
at hudson.ExtensionList.load(ExtensionList.java:381)
at hudson.ExtensionList.ensureLoaded(ExtensionList.java:317)
at hudson.ExtensionList.getComponents(ExtensionList.java:183)
at jenkins.model.Jenkins$6.onInitMilestoneAttained(Jenkins.java:1161)
at jenkins.InitReactorRunner$1.onAttained(InitReactorRunner.java:84)
at org.jvnet.hudson.reactor.ReactorListener$Aggregator.lambda$onAttained$3(ReactorListener.java:102)
at org.jvnet.hudson.reactor.ReactorListener$Aggregator.run(ReactorListener.java:109)
at org.jvnet.hudson.reactor.ReactorListener$Aggregator.onAttained(ReactorListener.java:102)
at org.jvnet.hudson.reactor.Reactor$1.run(Reactor.java:177)
at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:68)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
There was a problem hiding this comment.
Will recheck after merge of #5049.
There was a problem hiding this comment.
Yes I know, but I need time to retest.
| @@ -20,7 +20,7 @@ windows-slaves 1.547 1.0 | |||
| antisamy-markup-formatter 1.553 1.0 | |||
| matrix-project 1.561 1.0 | |||
| junit 1.577 1.0 | |||
| bouncycastle-api 2.16 2.16.0 | |||
| bouncycastle-api 2.18 2.16.0 | |||
| @@ -159,7 +159,6 @@ public void moduleClassesShouldBeWhitelisted() throws Exception { | |||
| ClassFilterImpl filter = new ClassFilterImpl(); | |||
| filter.check("org.jenkinsci.main.modules.cli.auth.ssh.UserPropertyImpl"); | |||
| filter.check("org.jenkinsci.modules.windows_slave_installer.WindowsSlaveInstaller"); | |||
| filter.check("org.jenkinsci.main.modules.instance_identity.PageDecoratorImpl"); | |||
There was a problem hiding this comment.
No longer a module, so no longer relevant to test.
timja
added
needs-comments-resolved
|
Nope, cannot do this yet—need to do Turns out doing them all together, as in #3988, was easier than trying to do one module at a time. |
MarkEWaite
added
the
unresolved-merge-conflict
|
Now would like to merge |
|
Have not had time to work on this. |
11 tasks
|
Completed in #6570. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of jenkinsci/instance-identity-plugin#17.
Requires #5049 becausesshddepends oninstance-identity(for real).Proposed changelog entries
instance-identitymodule into a (detached) plugin.Proposed upgrade guidelines
Normally the new plugin will be automatically installed. If you use an “as-code” installation mechanism like a text file with a list of plugins, you may need to add
instance-identity(version3.0or later) in order to restore this functionality.Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).