Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-59412] No reason why User/builds or View/builds should not work with Pipeline #5465

Merged
merged 2 commits into from
May 8, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented May 6, 2021

See JENKINS-59412. #4207 was mistaken. While Computer/builds is truly incompatible with Pipeline for reasons explained in JENKINS-38877, User/builds can be made compatible with only simple changes, and View/builds was already fine.

Proposed changelog entries

  • Displaying Pipeline builds among user build history, and removing incorrect warning about view build history.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label May 6, 2021
@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 7, 2021
@timja
Copy link
Member

timja commented May 7, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja merged commit 50818f1 into jenkinsci:master May 8, 2021
@jglick jglick deleted the builds-JENKINS-59412 branch May 10, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
5 participants