Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox missing fill color #5536

Merged
merged 2 commits into from
May 29, 2021
Merged

Conversation

Wadeck
Copy link
Contributor

@Wadeck Wadeck commented May 27, 2021

In #4763, the tick of the checkbox in the login page for the "remember me" part was changed.

Version 2.222

Screenshot_2021-05-27_110854_001

Version 2.277

Screenshot_2021-05-27_110837_001

After this PR

Screenshot_2021-05-27_111939_001


The impact seems pretty limited as it's only used in 2-3 pages, not application wide.

Proposed changelog entries

  • Better contrast for the checkbox in the login page

Proposed upgrade guidelines

N/A

Submitter checklist

  • [n/a] (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • [n/a] Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@oleg-nenashev @timja @fqueiruga

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@Wadeck Wadeck changed the title Checkbox missing fill Checkbox missing fill color May 27, 2021
@Wadeck Wadeck added the web-ui The PR includes WebUI changes which may need special expertise label May 27, 2021
@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label May 27, 2021
@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 27, 2021
@timja
Copy link
Member

timja commented May 27, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja merged commit 63920b6 into jenkinsci:master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
5 participants