Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-66094]Use Path.startsWith() for subdirectory check when unzipping #5613

Merged
merged 1 commit into from
Jul 25, 2021

Conversation

trgpa
Copy link
Contributor

@trgpa trgpa commented Jul 8, 2021

See JENKINS-66094.

Proposed changelog entries

  • Fix an issue unzipping archives in a corner case when entries have the same path prefix as the target location.

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@Wadeck @batmat

@Wadeck
Copy link
Contributor

Wadeck commented Jul 13, 2021

(Testing still in progress, requires lot of time, but I don't have much 🤷‍♂️)

Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trungPa for the PR, I was testing it with tens of different locations and there is no regression, great job!

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 22, 2021
@basil
Copy link
Member

basil commented Jul 22, 2021

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil
Copy link
Member

basil commented Jul 23, 2021

@trungPa Could you please update the PR description with an appropriate changelog entry for end users? Something like: "Fix an issue unzipping archives in a corner case when entries have the same path prefix as the target location."

@basil basil added the bug For changelog: Minor bug. Will be listed after features label Jul 23, 2021
@res0nance res0nance merged commit b8127af into jenkinsci:master Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
4 participants