Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-66968] Fix scaling of buttons in security realm #5849

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Oct 24, 2021

Use a medium sized gear sprite in the security realm overview to match with the delete button size.

Before:

After:

Proposed changelog entries

Fix scaling of buttons in the security realm overview

Submitter checklist

  • (If applicable) Jira issue is well described: https://issues.jenkins.io/browse/JENKINS-66968
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@oleg-nenashev oleg-nenashev added bug For changelog: Minor bug. Will be listed after features web-ui The PR includes WebUI changes which may need special expertise ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback labels Oct 24, 2021
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need backporting of this defect into the next LTS baseline? It seems to be minor, but at the same time backporting is straightforward. @NotMyFault could you please create a Jira issue so that we could consider it for backporting?

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@NotMyFault NotMyFault changed the title Fix scaling of buttons in security realm [JENKINS-66968] Fix scaling of buttons in security realm Oct 24, 2021
@NotMyFault
Copy link
Member Author

Do we need backporting of this defect into the next LTS baseline? It seems to be minor, but at the same time backporting is straightforward. @NotMyFault could you please create a Jira issue so that we could consider it for backporting?

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

I wasn't sure whether this is worth to be included in the next LTS or not, hence no issue till now, as it being a quite minor fix. However, I've risen an issue at https://issues.jenkins.io/browse/JENKINS-66968

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Perhaps it makes sense to look into whether both icons could be on the same line? Seems odd to have them stacked. This PR makes sense as is though.

@daniel-beck
Copy link
Member

Do we need backporting of this defect into the next LTS baseline?

No.

@daniel-beck daniel-beck added the skip-changelog Should not be shown in the changelog label Oct 24, 2021
@timja timja merged commit 12ffe65 into jenkinsci:master Oct 25, 2021
@NotMyFault NotMyFault deleted the fix/master/wrong-icon-scaling-in-security-realm branch October 25, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
5 participants