Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-67028] Fix missing project hyperlink in build history #5875

Merged

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Nov 1, 2021

Fixes https://issues.jenkins.io/browse/JENKINS-67028

Proposed changelog entries

  • Fix missing hyperlink in build history (regression in 2.314).

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade

Desired reviewers

@MarkEWaite

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Nov 1, 2021
@MarkEWaite
Copy link
Contributor

Thanks very much @NotMyFault ! I've tested interactively and confirmed that the hyperlink is inserted in the build history and links as expected to the build details page.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me taking the neighboring changes. Thanks for the patch!

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise labels Nov 2, 2021
@MarkEWaite
Copy link
Contributor

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

Let's wait to merge this until after the Jenkins 2.319 weekly release is delivered on Thursday, Nov 4, 2021. Merging earlier won't make the fix available any sooner and delaying the merge will allow each PR submitter to handle the merge rather than placing the merge burden on the Jenkins security team.

@timja timja merged commit 2ad5d26 into jenkinsci:master Nov 4, 2021
@MarkEWaite MarkEWaite changed the title Fix missing project hyperlink in build history [JENKINS-67028] Fix missing project hyperlink in build history Nov 9, 2021
cathychan pushed a commit to cathychan/jenkins that referenced this pull request Nov 15, 2021
@NotMyFault NotMyFault deleted the fix/master/hyperlink-buildhistory branch December 15, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
4 participants