Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve artifact list readability in dark theme #5889

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Nov 5, 2021

Currently the artifact list (for sufficiently many artifacts) looks wrong in dark theme:
artifacts-before
This PR makes the background transparent
artifacts-after

Proposed changelog entries

  • Improve artifact list readability in dark theme.

Proposed upgrade guidelines

N/A

Submitter checklist

  • [n/a] (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • [n/a] Appropriate autotests or explanation to why this change has no tests
  • [n/a] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@fqueiruga @timja

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@zbynek
Copy link
Contributor Author

zbynek commented Nov 5, 2021

CC @janfaracik in case this is conflicted with your UI cleanup

@timja timja added skip-changelog Should not be shown in the changelog rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed skip-changelog Should not be shown in the changelog labels Nov 5, 2021
@janfaracik
Copy link
Contributor

CC @janfaracik in case this is conflicted with your UI cleanup

LGTM :)

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(FTR this is shown between 16 and 40 files)

@timja timja merged commit 3e8a11a into jenkinsci:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
5 participants