Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enable form element path in unit tests by default #6004

Merged
merged 2 commits into from Dec 4, 2021

Conversation

timja
Copy link
Member

@timja timja commented Dec 3, 2021

Reports that HtmlUnit isn't performant enough...

see jenkinsci/bom#746 (comment)

Draft till it's validated this fixes it

See JENKINS-XXXXX.

Proposed changelog entries

  • Developer: Disable form element path in unit tests by default.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Reports that HtmlUnit isn't performant enough...
@timja timja added the bug For changelog: Minor bug. Will be listed after features label Dec 3, 2021
@timja timja requested a review from jglick December 3, 2021 08:37
@jglick jglick mentioned this pull request Dec 3, 2021
10 tasks
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the question is whether ATH is explicitly enabling this via system property?

@timja
Copy link
Member Author

timja commented Dec 3, 2021

So the question is whether ATH is explicitly enabling this via system property?

it is already, I just wanted to PR bom first to make sure this fixes it

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 3, 2021
@timja timja marked this pull request as ready for review December 3, 2021 17:00
@basil basil merged commit 14a763b into jenkinsci:master Dec 4, 2021
@basil basil added developer Changes which impact plugin developers and removed bug For changelog: Minor bug. Will be listed after features labels Dec 4, 2021
@timja timja deleted the disable-form-element-path-by-default branch December 4, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
3 participants