Backporting for LTS 2.319.3 (additional backports) #6235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imonteroperez
requested review from
timja,
MarkEWaite,
Wadeck,
jtnord and
daniel-beck
|
seems somewhat strange to me to have so many issues backported that are not even in a weekly release. |
timja
reviewed
Jan 31, 2022
| onChoose: function (event) { | ||
| const draggableDiv = event.item; | ||
| const height = draggableDiv.clientHeight; | ||
| draggableDiv.style.height = `${height}px`; |
There was a problem hiding this comment.
not compatible with IE 11 as is, this LTS line still supports it so would need to be adjusted like so:
Suggested change
| draggableDiv.style.height = `${height}px`; | |
| draggableDiv.style.height = height + 'px'; |
they look generally low risk to me but I don't see a rush in backporting them, most of them can be backported to the next LTS line. +1 on JENKINS-67635 though and JENKINS-67702 is probably fine too |
…ls (jenkinsci#6193) (cherry picked from commit 691bc95) (cherry picked from commit c392147)
imonteroperez
force-pushed
the
towards-2.319.3-additional-backports
branch
from
c392147
to
ab95dd7
Compare
timja
approved these changes
Jan 31, 2022
Bumps [xstream](https://github.com/x-stream/xstream) from 1.4.18 to 1.4.19. - [Release notes](https://github.com/x-stream/xstream/releases) - [Commits](https://github.com/x-stream/xstream/commits) --- updated-dependencies: - dependency-name: com.thoughtworks.xstream:xstream dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 79e27f0)
Wadeck
approved these changes
Feb 1, 2022
daniel-beck
approved these changes
Feb 1, 2022
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from: #6187