Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-41218] Use systemd for Linux installers #6333

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Mar 4, 2022

JENKINS-41218 Use systemd for Linux installers instead of System V init

See Jenkins developers mailing list discussion for more details.

The Linux installers for Jenkins 2.335, 2.336, and 2.337 weekly releases use systemd instead of System V init. They include migration steps that read the existing System V init script settings and convert them to systemd override configuration settings.

The systemd service has been the default and the preferred system and service manager on most Linux distributions for many years. Jenkins use of systemd unifies the service management method across all three of our Linux installers and allows us to describe configuration actions for Debian, Red Hat, and SUSE installers with a single set of instructions.

Resolves the following known issues with the Linux installers:

  • JENKINS-41218 - Switch Linux installers from System V init to systemd
  • JENKINS-65809 - Restart the Jenkins service after plugin updates on Debian 11 (bullseye)
  • JENKINS-56219 - Restart systemd service when the controller exits unexpectedly
  • JENKINS-31656 - Return zero from RPM init script on successful stop
  • JENKINS-67487 - Correctly report startup result on Amazon Linux 2 installed with the rpm package
  • JENKINS-67404 - Do not fail startup with timeout on systems with slow DNS resolution

Changes include:

Proposed changelog entries

  • Use systemd based Linux installers instead of installers based on System V init.

Proposed upgrade guidelines

Jenkins installers for Linux packages now use systemd to manage the configuration settings and the Jenkins service. Settings from the previous System V based init installations are migrated to systemd during package upgrade. Configuration setting changes are now performed with the command systemctl edit jenkins on all Linux packages.

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@basil

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

basil and others added 5 commits March 4, 2022 15:14
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
(cherry picked from commit 7915d82)
API additions that were cherry-picked to 2.332.1
@MarkEWaite MarkEWaite added the into-lts This PR is filed against an LTS branch label Mar 4, 2022
@MarkEWaite MarkEWaite requested a review from basil March 5, 2022 00:37
@MarkEWaite MarkEWaite added the upgrade-guide-needed This changes might be breaking in rare circumstances, an entry in the LTS upgrade guide is needed label Mar 5, 2022
@MarkEWaite MarkEWaite changed the title Use systemd for Linux installers [JENKINS-41218] Use systemd for Linux installers Mar 5, 2022
@basil
Copy link
Member

basil commented Mar 5, 2022

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 5, 2022
@basil basil merged commit 8a307ab into jenkinsci:stable-2.332 Mar 6, 2022
@MarkEWaite MarkEWaite deleted the stable-2.332-use-systemd-for-linux-installer branch April 14, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
into-lts This PR is filed against an LTS branch ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback upgrade-guide-needed This changes might be breaking in rare circumstances, an entry in the LTS upgrade guide is needed
Projects
None yet
4 participants