Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align shutdown banner, starvation and add a sidepanel to the plugin uninstallation view #6457

Merged

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Apr 10, 2022

The shutdown banner does now have less sharp edges and aligns with other top banners, e.g. update center warnings:

Additionally, I aligned the executor starvation icon with other build widget icons like cancelling builds or the offline widget:

The uninstallation view does now have a sidepanel as well.

Proposed changelog entries

  • Align shutdown banner with other top banners, align executor starvation icon with other build widget icons, and add a side panel to the plugin uninstallation view.

Proposed upgrade guidelines

N/A

Submitter checklist

  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault force-pushed the feat/master/align-warnings-and-misc branch from 035024c to 9430bf3 Compare April 10, 2022 18:59
@NotMyFault NotMyFault changed the title Align shutdown banner, starvation and add links to plugin uninstallation view Align shutdown banner, starvation and add a sidepanel to the plugin uninstallation view Apr 10, 2022
@NotMyFault NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Apr 12, 2022
Co-authored-by: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 12, 2022
@timja
Copy link
Member

timja commented Apr 12, 2022

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@basil basil added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Apr 13, 2022
@basil basil merged commit fe8213b into jenkinsci:master Apr 13, 2022
@NotMyFault NotMyFault deleted the feat/master/align-warnings-and-misc branch April 13, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
4 participants