Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68735] Missing sidepanel for user configuration if password is empty #6650

Merged
merged 2 commits into from
Jun 12, 2022
Merged

[JENKINS-68735] Missing sidepanel for user configuration if password is empty #6650

merged 2 commits into from
Jun 12, 2022

Conversation

Langer0416
Copy link
Contributor

@Langer0416 Langer0416 commented Jun 11, 2022

See JENKINS-68735.

This also happens if you enter a different password between password and confirm password.

Before:
Before
After:
After

Proposed changelog entries

  • Add sidepanel if users enter an empty password or it differs between the current and the new one.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@Langer0416 Langer0416 changed the title [Jenkins-68735] Missing sidepanel for user configuration if password is empty [JENKINS-68735] Missing sidepanel for user configuration if password is empty Jun 11, 2022
@NotMyFault NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jun 11, 2022
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather a bug than RFE IMHO, but looks good otherwise.

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 11, 2022
@MarkEWaite MarkEWaite added bug For changelog: Minor bug. Will be listed after features and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jun 11, 2022
@NotMyFault NotMyFault merged commit 393ec80 into jenkinsci:master Jun 12, 2022
@daniel-beck
Copy link
Member

daniel-beck commented Jun 13, 2022

This should not have been merged, as it changes the AbstractModelObject error page, which may be used for more than just User. Any callers of AbstractModelObject#sendError redirect here, e.g.
Screenshot 2022-06-13 at 16 46 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
5 participants