Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and simplify SCSS classes and variables #6667

Merged
merged 18 commits into from
Jun 22, 2022

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jun 16, 2022

This is a small PR to improve and simplify some classes and variables used in Jenkins.

  • The small border animation on clicked/focused elements is now a reusable mixin, which cuts down on code duplication and brings greater consistency to the newer Jenkins components
  • The item() mixin (as described above, happy to hear suggestions for a better name) now uses variables for its background/shadow meaning that it's more theme-able than before
  • Manage Jenkins SCSS has moved to the /pages folder
  • Minor font size changes to the Manage Jenkins to bring more balance to the page + make it more responsive
  • The plugin update bubble now pops in on page load for increased visibility
Screen.Recording.2022-06-16.at.17.46.07.mov
  • Some very minor color changes to increase vibrancy
  • A new keyboard focus state for components using the item() mixin

image

Proposed changelog entries

  • N/A (alternatively Minor color changes to UI components)

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Jun 16, 2022
@timja timja requested a review from a team June 16, 2022 21:03
@timja timja added the web-ui The PR includes WebUI changes which may need special expertise label Jun 16, 2022
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested via gitpod and compared it with https://weekly.ci.jenkins.io

@timja timja requested a review from a team June 17, 2022 06:37
@NotMyFault
Copy link
Member

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@NotMyFault NotMyFault added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 18, 2022
@timja timja merged commit c156880 into jenkinsci:master Jun 22, 2022
@timja timja deleted the move-manage-jenkins-less branch June 22, 2022 22:16
basil pushed a commit to basil/jenkins that referenced this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
3 participants