Add sidebar to plugin manager, increase search bar size #6783
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| <!-- | ||
|
There was a problem hiding this comment. It would be helpful if the new side panel pattern would be exposed as tags in There was a problem hiding this comment. Definitely 👍 If it's alright with you though I'd like to wait a bit to have a more concrete design across Jenkins before building a new component/tag for these new sorts of sidebar behaviours as they may change/be tweaked still depending on future PRs. For the most part though replicating this shouldn't be too hard with the There was a problem hiding this comment. I am not sure if this is a good idea. As @daniel-beck noted as well:
I think we should start very soon with creating and documenting a control for that (and maybe opening a discussion about the new concept can and should be used in plugins). Or when do you expect that others will pick up those changes for their plugins? Then we should at least notify everybody that this concept is not yet mature and should not be applied in plugins. There was a problem hiding this comment. There was a problem hiding this comment. The configure project is updated as part of #7051. The plugin manager on the other hand has been changed (I should probably update the opening post) to get sign off from Daniel so the title of the page is now above the search bar. This could change in the future in which case I'll definitely adopt the way #7051 does it 👍 There was a problem hiding this comment. I didn't really follow the explanation regarding the relationship between this PR and #7051, but I trust that we are making progress. My primary concern is that the design pattern codified in #7051 is consistently followed by all implementations, including the configure project page and the plugin manager page (this PR) as well as any future pages that are converted to this pattern. The order of operations seems like it is up for debate, but my main concern is just that we reach the desired end state and not that we take any particular order of operations to get there. I would expect that it would be desirable to fully flesh out the API in #7051 before adding new implementations as in this PR, because otherwise those implementations would then need to be adjusted later to conform to the final API. But I could be wrong about this. Either way, I think we should get the API finalized and all implementations conforming before we convert more pages to this paradigm. |
||
| The MIT License | ||
|
|
||
| Copyright (c) 2022, Jenkins contributors | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
|
|
@@ -23,17 +23,19 @@ THE SOFTWARE. | |
| --> | ||
|
|
||
| <!-- | ||
| Sidepanel component for Plugins Manager | ||
| --> | ||
| <?jelly escape-by-default='true'?> | ||
| <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt"> | ||
| <l:side-panel> | ||
| <l:tasks> | ||
| <l:task href="${rootURL}/manage/pluginManager/" icon="symbol-download" title="${%Updates}"/> | ||
| <l:task href="${rootURL}/manage/pluginManager/available" icon="symbol-shopping-bag" title="${%Available plugins}"/> | ||
| <l:task href="${rootURL}/manage/pluginManager/installed" icon="symbol-plugins" title="${%Installed plugins}"/> | ||
| <l:task href="${rootURL}/manage/pluginManager/advanced" icon="symbol-settings" title="${%Advanced settings}"/> | ||
| <j:if test="${!app.updateCenter.jobs.isEmpty()}"> | ||
| <l:task href="${rootURL}/manage/pluginManager/updates/" icon="symbol-list" title="${%Download progress}"/> | ||
| </j:if> | ||
| </l:tasks> | ||
| </l:side-panel> | ||
| </j:jelly> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
Detail - Categorya reasonable presentation universal across languages Jenkins is translated to?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question and something I haven't got a concrete answer to. I've given it a quick Google but haven't found any articles on the topic, so I've looked at how various sites behave with right-to-left languages:
Google Search - Doesn't change the hierarchy of the title (e.g. Jenkins - Google)
Wikipedia - Does change the hierarchy of the title (e.g. Wikipedia - Jenkins)
Google Translate - Does change the hierarchy of the title