[JENKINS-68801] - Fix for Functions#extractPluginNameFromIconSrc

[bzzitsme]

See JENKINS-68801.

If our plugin's artifactId will contain "plugin-", then it will replace all "plugin-" occurences instead of first one.
Then it won't be able to correctly extract plugin name

Proposed changelog

• Use correct icon lookup even when plugin ID includes more than one occurrence of "plugin".

Proposed upgrade guidelines

N/A

Submitter checklist

• (If applicable) Jira issue is well described
• Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• Appropriate autotests or explanation to why this change has no tests
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
• For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@timja @janfaracik

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[bzzitsme]

Hi @janfaracik @timja
Could you take a look at this PR?

[timja]

/reviewer @jenkinsci/sig-ux

[timja]

Is this a theoretical issue or do you have a plugin which includes the text plugin- in it?

[bzzitsme]

Is this a theoretical issue or do you have a plugin which includes the text plugin- in it?

We have plugin which contains "plugin-" in the artifactId

[daniel-beck]

There's also https://plugins.jenkins.io/plugin-util-api/ https://plugins.jenkins.io/plugin-usage-plugin/ https://plugins.jenkins.io/cloudbees-plugin-gateway/ https://plugins.jenkins.io/icn-plugin-loader/ which might hit this.

[timja]

(untested, but I assume you have)

[timja]

/reviewer @jenkinsci/sig-ux

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[bzzitsme]

(untested, but I assume you have)

I have tested it and it works fine

[yaroslavafenkin]

Looks reasonable to me.
Do we maybe want to add a tiny unit test for this? E.g. FunctionsTest.java#L398

[bzzitsme]

Do we maybe want to add a tiny unit test for this? E.g. FunctionsTest.java#L398

Added test for new functionality

[NotMyFault]

I went ahead and fixed your spot bugs issues introduced, hope you don't mind.

---

/label ready-for-merge

---

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

[comment-ops-bot]

I wasn't able to add the following labels: ready-for-merge

---

This PR is now ready for merge

Check that the label exists and is spelt right then try again.

[timja]

(labelling with other text is currently broken, it will work on it's own)