Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-69145] bouncing build number element on mouse hover #6928

Merged
merged 5 commits into from Aug 30, 2022

Conversation

frankie139506
Copy link
Contributor

@frankie139506 frankie139506 commented Jul 27, 2022

See JENKINS-69145.

Proposed changelog entries

  • Fix bouncing build number element on mouse hover.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Jul 27, 2022
@daniel-beck
Copy link
Member

Would this also take care of JENKINS-68160?

@frankie139506
Copy link
Contributor Author

frankie139506 commented Jul 30, 2022

Would this also take care of JENKINS-68160?

Yes, it also fix JENKINS-68160's problem.

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change it is no longer possible to access the context menu dropdown of model-links. The hover state collapses before I can move the pointer to the chevron.

Screen.Recording.2022-07-30.at.10.18.27.mov

@frankie139506
Copy link
Contributor Author

With this change it is no longer possible to access the context menu dropdown of model-links. The hover state collapses before I can move the pointer to the chevron.

Screen.Recording.2022-07-30.at.10.18.27.mov

@daniel-beck In my test, it is normal, This is my demo.
gif2

@daniel-beck
Copy link
Member

daniel-beck commented Jul 30, 2022

Move your mouse pointer more slowly. I found it sometimes works when moving the pointer fairly quickly.

Otherwise, I used Firefox 103 and most pages have some level of zoom >100%, probably was the case here too.

@frankie139506
Copy link
Contributor Author

Move your mouse pointer more slowly. I found it sometimes works when moving the pointer fairly quickly.

Otherwise, I used Firefox 103 and most pages have some level of zoom >100%, probably was the case here too.

Thanks for your suggestion. I have make some change, please take a look.
gif2

@NotMyFault NotMyFault requested review from daniel-beck and a team July 31, 2022 21:17
@daniel-beck
Copy link
Member

The latest state of this no longer causes the issue when slowly moving the mouse pointer 👍

Not approving as of now as I've only inconsistently been able to reproduce JENKINS-68160. Requesting @jtnord as the reporter of JENKINS-69145.

@jtnord
Copy link
Member

jtnord commented Aug 1, 2022

I can verify that JENKINS-69145 is indeed fixed, thankyou!

@frankie139506
Copy link
Contributor Author

Could I get a reviewer for this PR?

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the problem in JENKINS-69145 on weekly.ci.j.io and this PR appears to address it.

Ideally @janfaracik could tell us what the purpose of pointer-events: all was here.

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Misclicked in the previous review.)

@NotMyFault
Copy link
Member

@janfaracik Do you mind taking a look and could clarify Daniel's open concerns?

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback squash-merge-me Unclean or useless commit history, should be merged only with squash-merge labels Aug 29, 2022
@basil basil merged commit f227350 into jenkinsci:master Aug 30, 2022
@basil
Copy link
Member

basil commented Sep 2, 2022

Manually verified as of commit 93f69b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
5 participants