Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-69232] Drop down select input is out of style with other drop down select input #6962

Merged
merged 5 commits into from Aug 8, 2022
Merged

[JENKINS-69232] Drop down select input is out of style with other drop down select input #6962

merged 5 commits into from Aug 8, 2022

Conversation

ridemountainpig
Copy link
Contributor

@ridemountainpig ridemountainpig commented Aug 4, 2022

See JENKINS-69232.

Before

截圖 2022-08-04 上午12 14 47

After

截圖 2022-08-04 下午2 20 44

Proposed changelog entries

  • Drop down select input is out of style with other drop down select input

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added web-ui The PR includes WebUI changes which may need special expertise bug For changelog: Minor bug. Will be listed after features needs-security-review Awaiting review by a security team member labels Aug 4, 2022
@NotMyFault NotMyFault requested a review from a team August 4, 2022 21:28
@NotMyFault NotMyFault changed the title JENKINS-69232 Drop down select input is out of style with other drop down select input [JENKINS-69232] Drop down select input is out of style with other drop down select input Aug 4, 2022
@NotMyFault NotMyFault requested a review from a team August 5, 2022 08:37
@ridemountainpig
Copy link
Contributor Author

ridemountainpig commented Aug 5, 2022

this block should be indented after adding one around it

I have indented it in new commit.

Thanks~

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change looks correct although I wasn't able to reproduce this issue from:

Freestyle job configure -> Execute shell -> Advanced -> Environment filters

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see now, it's the arrow on the far right of the select, quite subtle :)

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as #6963 (review)

@daniel-beck daniel-beck added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Aug 5, 2022
@ridemountainpig
Copy link
Contributor Author

Same concern as #6963 (review)

I have fix this question.

Thanks~

@NotMyFault NotMyFault removed the request for review from a team August 5, 2022 16:20
@NotMyFault
Copy link
Member

/label ready-for-merge


Thanks for addressing!


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 5, 2022
@NotMyFault NotMyFault added skip-changelog Should not be shown in the changelog and removed bug For changelog: Minor bug. Will be listed after features labels Aug 5, 2022
@timja timja merged commit 248830a into jenkinsci:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback security-approved @jenkinsci/core-security-review reviewed this PR for security issues skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
4 participants