[JENKINS-69257] Model link chevron is not in center in user build cause

[ridemountainpig]

See JENKINS-69257.

After

Proposed changelog entries

• Model link chevron is not in center in user build cause

Proposed upgrade guidelines

N/A

Submitter checklist

• (If applicable) Jira issue is well described
• Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• Appropriate autotests or explanation to why this change has no tests
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content-Security-Policy directives (see documentation on jenkins.io).
• For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[NotMyFault]

Untested, but the change proposed looks like it places existing chevrons lower and therefore dealigns them from being centered

Edit: Yes it does:

[ridemountainpig]

Untested, but the change proposed looks like it places existing chevrons lower and therefore dealigns them from being centered

I have using without adding margin-top in jenkins-menu-dropdown-chevron to fix one in this issue, but another one I couldn't find where to fix it, if anyone have any idea welcome give the comment.

[basil]

The question I asked in #6970 (comment) remains unacknowledged.

[daniel-beck]

The question I asked in #6970 (comment) remains unacknowledged.

My feedback was wrong and the problem I expected does not actually occur.

[basil]

Confirmed that this fixes JENKINS-69257 as follows:

• Checked out jenkins-2.320
• Confirmed that git grep jenkins-table__link returned no results
• Compiled the code
• Built a freestyle project and confirmed the chevron was at the center line
• Checked out the latest tip-of-trunk with the changes from this PR
• Compiled the code
• Looked at the existing build from before the upgrade, verified that chevron was aligned in the middle

Confirmed that this does not fix JENKINS-69602, which will remain open after this PR is merged.

[NotMyFault]

Thanks for addressing the feedback!

[basil]

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!