-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Russian translation of job config page items #7230
Conversation
core/src/main/resources/hudson/model/AbstractProject/help-concurrentBuild_ru.html
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/model/BooleanParameterDefinition/config_ru.properties
Show resolved
Hide resolved
core/src/main/resources/hudson/tasks/Maven/config_ru.properties
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/triggers/TimerTrigger/help_ru.html
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/triggers/TimerTrigger/help_ru.html
Outdated
Show resolved
Hide resolved
.../src/main/resources/jenkins/tasks/filters/impl/RetainVariablesLocalRule/config_ru.properties
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some terms sound so weird in russian and are probably more confusing than if they weren't translated. Or maybe it's just me :D
.../src/main/resources/jenkins/tasks/filters/impl/RetainVariablesLocalRule/config_ru.properties
Outdated
Show resolved
Hide resolved
@yaroslavafenkin this is definitely a challenge, a lot of people discuss such technical things in halfway-English 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I was worried that the Mojibake in core/src/main/resources/hudson/triggers/TimerTrigger/help_ru.html
was a more widespread problem and/or a recent regression, but (fortunately!) neither appears to be the case. This particular file appears to have been corrupted over a decade ago in commit 825dc6d. I found and fixed a few other isolated cases like this in #7248, #7249, and #7250, all of which date back to the same time period. Hopefully the consistent use of UTF-8 encoding introduced in #6719 will make it harder for these kinds of errors to be introduced in the future.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit late, but here is my 🐝 as well :)
I checked thoroughly the first ten files the rest just skimmed since it all looks pretty good.
It was corrupted even before that. The old version isn't readable Russian either 😄 It probably somehow slipped through in the first commit, then I guess someone's IDE tried to decode it and corrupted it worse. The new version was absolutely unrecoverable after getting baked twice, but I was able to put the old version into an automatic encoding switch tool and recover the initial content, then apply the changes from the next commits back to it. |
Between the archaeological work done in this PR, #7248, #7249, and #7250, I think we have eradicated mojibake from this repository. I ran the |
Translations of many items and options on the job config page, fixing of a couple misspellings, and uncorrupting one help button blurb corrupted by bad encoding.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@Pldi23 @yaroslavafenkin @duemir
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).