Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian translation of job config page items #7230

Merged
merged 12 commits into from
Oct 13, 2022

Conversation

Riliane
Copy link
Contributor

@Riliane Riliane commented Oct 7, 2022

Translations of many items and options on the job config page, fixing of a couple misspellings, and uncorrupting one help button blurb corrupted by bad encoding.

Proposed changelog entries

  • Add translation of the job configuration page content into Russian

Proposed upgrade guidelines

N/A

Submitter checklist

  • [N/A] The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • [N/A] There is automated testing or an explanation as to why this change has no tests.
  • [N/A] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • [N/A] New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • [N/A] New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • [N/A] For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • [N/A] For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@Pldi23 @yaroslavafenkin @duemir

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added localization hacktoberfest-accepted Regardless of the change status, this is a valid Hacktoberfest PR labels Oct 7, 2022
Copy link
Contributor

@yaroslavafenkin yaroslavafenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some terms sound so weird in russian and are probably more confusing than if they weren't translated. Or maybe it's just me :D

Riliane and others added 3 commits October 10, 2022 12:14
Co-authored-by: Yaroslav <91559310+yaroslavafenkin@users.noreply.github.com>
@Riliane
Copy link
Contributor Author

Riliane commented Oct 10, 2022

@yaroslavafenkin this is definitely a challenge, a lot of people discuss such technical things in halfway-English 😂
for example, "хуки post-commit" stays a borrowed term.

@Riliane Riliane marked this pull request as ready for review October 10, 2022 16:34
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I was worried that the Mojibake in core/src/main/resources/hudson/triggers/TimerTrigger/help_ru.html was a more widespread problem and/or a recent regression, but (fortunately!) neither appears to be the case. This particular file appears to have been corrupted over a decade ago in commit 825dc6d. I found and fixed a few other isolated cases like this in #7248, #7249, and #7250, all of which date back to the same time period. Hopefully the consistent use of UTF-8 encoding introduced in #6719 will make it harder for these kinds of errors to be introduced in the future.


This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 12, 2022
Copy link
Member

@duemir duemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit late, but here is my 🐝 as well :)
I checked thoroughly the first ten files the rest just skimmed since it all looks pretty good.

@Riliane
Copy link
Contributor Author

Riliane commented Oct 13, 2022

Thanks for the PR! I was worried that the Mojibake in core/src/main/resources/hudson/triggers/TimerTrigger/help_ru.html was a more widespread problem and/or a recent regression, but (fortunately!) neither appears to be the case. This particular file appears to have been corrupted over a decade ago in commit 825dc6d. I found and fixed a few other isolated cases like this in #7248, #7249, and #7250, all of which date back to the same time period. Hopefully the consistent use of UTF-8 encoding introduced in #6719 will make it harder for these kinds of errors to be introduced in the future.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

It was corrupted even before that. The old version isn't readable Russian either 😄 It probably somehow slipped through in the first commit, then I guess someone's IDE tried to decode it and corrupted it worse. The new version was absolutely unrecoverable after getting baked twice, but I was able to put the old version into an automatic encoding switch tool and recover the initial content, then apply the changes from the next commits back to it.

@basil basil merged commit 165f552 into jenkinsci:master Oct 13, 2022
@basil
Copy link
Member

basil commented Oct 13, 2022

Between the archaeological work done in this PR, #7248, #7249, and #7250, I think we have eradicated mojibake from this repository. I ran the ftfy.badness.is_bad heuristic from this package on every line of every text file (as reported by file(1)) in this repository and could not find any remaining mojibake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Regardless of the change status, this is a valid Hacktoberfest PR localization ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
7 participants