Capturing runtime exceptions from Computer.threadPoolForRemoting.submit(Runnable)
#7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
reviewed
Oct 20, 2022
core/src/main/java/hudson/util/ExceptionCatchingThreadFactory.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Brandes <brandes.alexander@web.de>
jglick
commented
Oct 20, 2022
| @@ -131,9 +131,12 @@ protected void opened() { | |||
| LOGGER.fine(() -> "setting up channel for " + agent); | |||
| state.fireBeforeChannel(new ChannelBuilder(agent, Computer.threadPoolForRemoting)); | |||
| transport = new Transport(); | |||
| state.fireAfterChannel(state.getChannelBuilder().build(transport)); | |||
| LOGGER.fine(() -> "set up channel for " + agent); | |||
| return null; | |||
There was a problem hiding this comment.
This was coercing the lambda to a Callable based on the checked exception.
core/src/main/java/hudson/util/ExceptionCatchingThreadFactory.java
Outdated
Show resolved
Hide resolved
NotMyFault
approved these changes
Oct 21, 2022
timja
approved these changes
Nov 7, 2022
timja
approved these changes
Nov 7, 2022
comment-ops-bot
bot
added
the
ready-for-merge
|
@Vlatombe do you mind taking a look, please? I was holding off a merge, because Jesse requested your explicit review. |
Vlatombe
approved these changes
Nov 23, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spent a while trying to track down an issue which turned out to be an unchecked exception thrown out of
JnlpConnectionStateListener.afterChanneland swallowed byFutureTask, whichExceptionCatchingThreadFactorydoes not address.Proposed changelog entries
Computer.threadPoolForRemoting.Maintainer checklist
Before the changes are marked as
ready-for-merge:upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).