Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian translation: global tool configuration, new node #7321

Merged
merged 11 commits into from
Dec 2, 2022

Conversation

Riliane
Copy link
Contributor

@Riliane Riliane commented Oct 31, 2022

Translation of items on the global tool configuration, node monitors, new node screens. Includes fixing some typos and out of context mistranslations and a bit of unification of the terms used, updating an outdated help blurb, un-hardcoding some validation fail messages.

Proposed changelog entries

  • Add Russian translation of text on the global tool configuration, node monitors, new node screens page.

Proposed upgrade guidelines

N/A

Submitter checklist

  • [N/A] The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • [N/A] There is automated testing or an explanation as to why this change has no tests.
  • [N/A] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • [N/A] New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • [N/A] New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • [N/A] For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • [N/A] For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@yaroslavafenkin @Pldi23 @duemir

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added localization hacktoberfest-accepted Regardless of the change status, this is a valid Hacktoberfest PR labels Oct 31, 2022
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks especially for the i18n-ing of some fixed Strings :)

(no idea about the content itself ;) )

@@ -0,0 +1,5 @@
Back\ to\ Dashboard=Вернуться к главной странице
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

панели задач/панели управления maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are actually a bunch of disordered translations for "dashboard". "Вернуться к главной странице" which i found and duplicated, "На главную", "Домой". "Dashboard" itself is "ИнфоПанель" in one place. tbh, it's kind of a mess and once again we should probably stick to one and unify

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does anyone have a preference for the unified name of the dashboard? I'd rather not leave it like that. Maybe "панель управления" and "Вернуться к панели управления", but that makes me think of "control panel" like in Windows. alternately, "главная страница"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was leaning towards панель управления but now that I think of it it seems different (Control panel in Windows for example). Guess that makes панель задач a better option.
Maybe it can be left out to not block this PR and unified as a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"панель задач" also makes me kind of think of windows taskbar, so I guess it's on the same level as "панель управления", with a potential alternate meaning.

Riliane and others added 4 commits November 7, 2022 13:47
Co-authored-by: Yaroslav <91559310+yaroslavafenkin@users.noreply.github.com>
Co-authored-by: Dmitry Platonov <47667812+Pldi23@users.noreply.github.com>
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions. Looks good otherwise

@@ -0,0 +1,4 @@
Enable\ work\ directory=Включить рабочую директорию
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enable\ work\ directory=Включить рабочую директорию
Enable\ work\ directory=Использовать рабочую директорию агента

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to look for this in the UI if there's a help blurb with more context, but it seems undisplayed. is this property not an actually displayed rendered element?

<f:property title="${%Enable work directory}" field="workDirSettings" />

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
@NotMyFault NotMyFault requested review from duemir and removed request for duemir November 25, 2022 19:33
@NotMyFault
Copy link
Member

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 30, 2022
@NotMyFault NotMyFault merged commit d5b0733 into jenkinsci:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Regardless of the change status, this is a valid Hacktoberfest PR localization ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
8 participants