-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Russian translation: global tool configuration, new node #7321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks especially for the i18n-ing of some fixed Strings :)
(no idea about the content itself ;) )
core/src/main/resources/hudson/security/GlobalSecurityConfiguration/config_ru.properties
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/slaves/DumbSlave/newInstanceDetail_ru.properties
Outdated
Show resolved
Hide resolved
core/src/main/resources/jenkins/slaves/RemotingWorkDirSettings/config_ru.properties
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,5 @@ | |||
Back\ to\ Dashboard=Вернуться к главной странице |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
панели задач
/панели управления
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are actually a bunch of disordered translations for "dashboard". "Вернуться к главной странице" which i found and duplicated, "На главную", "Домой". "Dashboard" itself is "ИнфоПанель" in one place. tbh, it's kind of a mess and once again we should probably stick to one and unify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does anyone have a preference for the unified name of the dashboard? I'd rather not leave it like that. Maybe "панель управления" and "Вернуться к панели управления", but that makes me think of "control panel" like in Windows. alternately, "главная страница"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was leaning towards панель управления
but now that I think of it it seems different (Control panel
in Windows for example). Guess that makes панель задач
a better option.
Maybe it can be left out to not block this PR and unified as a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"панель задач" also makes me kind of think of windows taskbar, so I guess it's on the same level as "панель управления", with a potential alternate meaning.
…-translation-new-node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions. Looks good otherwise
core/src/main/resources/hudson/model/Slave/help-remoteFS_ru.html
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/model/Slave/help-remoteFS_ru.html
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/security/GlobalSecurityConfiguration/config_ru.properties
Show resolved
Hide resolved
core/src/main/resources/hudson/slaves/DumbSlave/configure-entries_ru.properties
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/slaves/DumbSlave/newInstanceDetail_ru.properties
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,4 @@ | |||
Enable\ work\ directory=Включить рабочую директорию |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable\ work\ directory=Включить рабочую директорию | |
Enable\ work\ directory=Использовать рабочую директорию агента |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried to look for this in the UI if there's a help blurb with more context, but it seems undisplayed. is this property not an actually displayed rendered element?
<f:property title="${%Enable work directory}" field="workDirSettings" />
/label ready-for-merge This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback. |
Translation of items on the global tool configuration, node monitors, new node screens. Includes fixing some typos and out of context mistranslations and a bit of unification of the terms used, updating an outdated help blurb, un-hardcoding some validation fail messages.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@yaroslavafenkin @Pldi23 @duemir
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).