-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address issues regarding Brazilian Portuguese translation and refactoring of Jelly/Properties files keys for JNLPLauncher
related views
#7353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
changed the title
Bugfix/pt br
Address issues regarding Brazilian Portuguese translation and refactoring of Jelly/Properties files keys for Nov 10, 2022
JNLPLauncher
related views
NotMyFault
approved these changes
Nov 10, 2022
NotMyFault
reviewed
Nov 10, 2022
...c/main/resources/jenkins/fingerprints/GlobalFingerprintConfiguration/config_pt_BR.properties
Outdated
Show resolved
Hide resolved
Also fixed keys due previous commit.
oleg-nenashev
approved these changes
Nov 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
core/src/main/resources/jenkins/fingerprints/GlobalFingerprintConfiguration/config.properties
Outdated
Show resolved
Hide resolved
…Configuration/config.properties Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
/label ready-for-merge This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback. |
comment-ops-bot
bot
added
the
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
label
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
localization
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Jenkins issue associated.
This PR fixes:
Testing done
Both changes were changed by compiling Jenkins, generating a new WAR file and checking the results in a browser. No visual change was identified, that was verified both by setting the browser to English (US) and Brazilian Portuguese.
Proposed changelog entries
JNLPLauncher
related views.Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).