Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-70115] The full width side panel's right side is too close to the border #7420

Merged
merged 4 commits into from Apr 27, 2023

Conversation

1weiho
Copy link
Contributor

@1weiho 1weiho commented Nov 19, 2022

See JENKINS-70115.

Before:
截圖 2022-11-20 上午1 17 48

After:
截圖 2022-11-20 上午1 17 40

Testing done

Proposed changelog entries

  • Add padding to the right side of the full width side panel.

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added needs-comments-resolved Comments in the PR need to be addressed before it can be considered for merging web-ui The PR includes WebUI changes which may need special expertise labels Nov 19, 2022
@1weiho
Copy link
Contributor Author

1weiho commented Nov 19, 2022

I have changed to target #tasks in body.two-column so that the executor and node widgets will not be affected.
image

@NotMyFault NotMyFault removed the needs-comments-resolved Comments in the PR need to be addressed before it can be considered for merging label Jan 13, 2023
@NotMyFault NotMyFault requested a review from a team January 13, 2023 15:33
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 21, 2023
@github-actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 21, 2023
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixes the corresponding issue on job configuration forms 👍

@timja
Copy link
Member

timja commented Apr 21, 2023

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 21, 2023
@NotMyFault NotMyFault added bug For changelog: Minor bug. Will be listed after features and removed web-ui The PR includes WebUI changes which may need special expertise labels Apr 27, 2023
@NotMyFault NotMyFault merged commit 06a19dc into jenkinsci:master Apr 27, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
6 participants