-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-70240] fix for non http based URLs in PluginManager.doCheckUpdateSiteUrl #7524
Conversation
- Local update centers use local json files which are valid - I have added the value.replace("file:/", ""); as when using a war, it adds 'file:/' to the path - This checks if the file is a valid file and if true returns FormValidation.ok
Update error message for when invalid URL message appears.
Updated wording on invalidURL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me; I fixed up the localizations and verified the new automated test passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!
update sites are not restricted to just http/https file based ones are also common.
Add support for file based url schemes in the doCheck to avoid an angry jenkins.
code will return a FormValidation error in the case an unsupported scheme is now used rather than an angry jenkins.
Update the help and translations.
subsumes #7520
See JENKINS-70240.
TODO: fix up stupid code charset mangling, and Manual dev testing still to be performed. (by the author)
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).